Fixes #6843: rename false-pin test case names in getObject/listObjects - #7229
Merged
Conversation
The case names claimed getObject(n) === get('object', n) and
listObjects() === list('object') equivalences, but the bodies only
assert that getObject/listObjects return what was registered — they
never call get()/list() to compare. Rename both to what they actually
assert; the equivalence itself is already gated by PR #6839's
metadata-service-getobject-equivalence.test.ts.
Fixes #6843
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016R9de1FqP7NvwKvqXi92Gh
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
📓 Docs Drift CheckNo hand-written docs reference the 0 changed package(s). ✅ |
os-help
added
the
skip-changeset
Claude
os-help
marked this pull request as ready for review
August 10, 2026 03:28
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6843
What
Two test-case names in
packages/metadata/src/metadata-service.test.tsclaimed an equivalence their bodies never exercised:'getObject should be shorthand for get("object", name)'→ renamed to'getObject returns the registered document''listObjects should be shorthand for list("object")'→ renamed to'listObjects returns the registered documents'Neither body ever calls
get()/list()to compare againstgetObject()/listObjects()— they only assert that the convenience method returns what was registered. The old names were a false prior-art signal for the next agent grepping for coverage of thegetObject(n)=get('object', n)equivalence.Names only — no assertion or coverage change.
Which disposition, and why
Issue #6843 listed three dispositions. The
domain:engine-coreseat's grading (2026-08-09T02:24Z, quoted in the issue thread) pre-approved disposition 1 (rename both cases) and explicitly refused disposition 2 (add aget('object', name)call and compare the pair): PR #6839 already gates this equivalence across four subjects, including MetadataManager on both of its resolution paths (packages/objectql/src/metadata-service-getobject-equivalence.test.ts), so adding a local pair-comparison here would be a knowingly-duplicated assertion whose only new content is making the old case name true.A later triage comment (06:50Z) said "make the case actually compare" — that's disposition 2, without engaging the seat's refusal. The PM's claim comment on the issue records the resolution: follow the seat's argued ruling, disposition 1. This PR does that.
Verified before implementing:
packages/objectql/src/metadata-service-getobject-equivalence.test.tsstill exists onorigin/mainwith the four-subject equivalence coverage described above, so disposition 2's refusal reason still holds.Tests
Fresh worktree, dependency closure built first:
No
typecheckscript on this package; type-checking happens via thetsupDTS build above, which succeeded clean.Changeset
Test-only rename, no user-visible behavior change →
skip-changesetcase. Applying the label after this PR is open.Generated by Claude Code