refactor(plugin-approvals,plugin-reports): annotate enforcement onto the full ExecutionContext (#7135)

.changeset/approvals-reports-exec-context-annotations.md

@@ -0,0 +1,57 @@
+---
+"@objectstack/plugin-approvals": patch
+"@objectstack/plugin-reports": patch
+---
+
+refactor(plugin-approvals,plugin-reports): enforcement implementations annotate the full `ExecutionContext` (#7135)
+
+The services half of #7070, mirroring what PR #7140 did for
+`plugin-sharing` / `plugin-audit`. #6523 converged 36 contract signatures onto
+the complete `resolveAuthzContext` envelope, applying the #6206 ruling —
+enforcement adjudicates on the whole envelope, never a per-site subset. The
+implementations behind those contracts still annotated their own parameters
+with the six-field shape the contracts used to name, so nothing they could
+*read* had widened.
+
+`ApprovalService`, the approval flow-node provider and `ReportService` now
+declare `ExecutionContext` on all 43 of those positions, and the casts the
+narrow annotation forced are gone:
+
+- `isOverrideActor()` read the derived `posture` (ADR-0095) through an
+  unchecked `(context as any)`. That gate decides whether a platform or tenant
+  admin may release a STUCK approval — one routed to an unstaffed position, the
+  only in-product recovery from a permanently locked record — so an erasure sat
+  directly on an enforcement input: a mistyped rung would have compiled and
+  silently denied every override. It is a declared read now.
+- Both services' `SYSTEM_CTX` is typed as the envelope and passed as itself,
+  retiring the `SYSTEM_CTX as unknown as …` double casts at the three sites
+  that hand it to a contract method.
+- The `(context as any).userId` / `.tenantId` reads in `ApprovalService` now
+  read declared fields.
+- `OwnerContextResolver` returns the envelope, which is what a scheduled report
+  actually resolves for its owner (#2849 / #2980).
+
+**No runtime behaviour changes.** The values were always complete — this
+family's damage was type-side — so every gate answers exactly what it answered
+before. Method parameters only WIDEN what they accept, so no caller is
+affected, and no public export changes shape.
+
+Casts deliberately kept, and now documented where they sit: `organizationId`
+is not a field of the envelope at all — that spelling has its own history
+(#5858 / `check:org-identifier`) and was held out of this change by #7070. In
+`approval-node.ts` the single remaining assertion exists only because the
+literal names that key; it was reduced from `as unknown as …` to a single
+`as ExecutionContext`, which still requires the literal to be comparable to
+the envelope.
+
+Because a re-narrowed annotation would compile, ship and pass every test in
+these packages, the convergence is pinned by a new compile-time module per
+package, `exec-context-annotation.pin.ts`: it hands each parameter a fresh
+literal naming envelope-only fields (`posture`, `accessible_org_ids`,
+`org_user_ids`), which TypeScript's excess-property check rejects the moment a
+parameter narrows back, plus negative cases so a parameter erased to `any`
+cannot pass either.
+
+The exported `SharingExecutionContext` type itself is NOT removed here: it is
+defined in `packages/spec`, which is single-owner, so its retirement is a
+separate follow-up.

packages/plugins/plugin-approvals/src/approval-node.ts

@@ -24,7 +24,10 @@ import {
   APPROVAL_NODE_TYPE,
   type ApprovalNodeConfig,
 } from '@objectstack/spec/automation';
-import type { SharingExecutionContext } from '@objectstack/spec/contracts';
+// [#7135] The full `resolveAuthzContext` envelope — what
+// `IApprovalService.openNodeRequest` declares for its context parameter since
+// #6523 (the #6206 ruling: no per-site subset contracts).
+import type { ExecutionContext } from '@objectstack/spec/kernel';
 import type { ApprovalService } from './approval-service.js';
 import { registerApprovalReviseNode } from './approval-revise-node.js';
 
@@ -55,7 +58,7 @@ interface MinimalLogger {
   warn?: (msg: any, ...rest: any[]) => void;
 }
 
-const SYSTEM_CTX = { isSystem: true, positions: [], permissions: [] } as const;
+const SYSTEM_CTX: ExecutionContext = { isSystem: true, positions: [], permissions: [] };
 
 /**
  * Rebuild the nested object the engine's CEL conditions see from the flow's
@@ -169,9 +172,20 @@ export function registerApprovalNode(
         }, {
           ...SYSTEM_CTX,
           userId: context?.userId,
+          // [#7135] ⚠️ This assertion SURVIVES the annotation widening, and it
+          // is `as ExecutionContext` rather than the `as unknown as
+          // SharingExecutionContext` double cast it replaces. The sole reason
+          // a cast is still needed is `organizationId`, which is not a field
+          // of the envelope at ALL — that spelling has its own history (#5858
+          // / `check:org-identifier`) and was explicitly held out of this
+          // change (#7070), so removing the key here would be a RUNTIME change
+          // belonging to that card. Dropping the second hop matters: `as
+          // unknown as` erases the value entirely, while a single assertion
+          // still requires the literal to be comparable to the envelope, so a
+          // `userId: 42` here is once again a compile error.
           organizationId: context?.organizationId,
           tenantId: context?.tenantId,
-        } as unknown as SharingExecutionContext);
+        } as ExecutionContext);
 
         // #3447 P2: empty slate + onEmptyApprovers: 'auto_approve' — nobody to
         // ask, no request row. Complete (don't suspend) straight down the