Repository navigation
docs(design): plugin-distribution names esbuild, as os plugin build bundles - #27723
Conversation
…undles The tree comment and section 5 step 1 named tsup; os plugin build bundles with esbuild into dist/index.mjs, externalizing @objectstack/* and inlining the rest. Claude-Session: https://claude.ai/code/session_01QSeKYmTYfaPbLQD4BJfomW Co-authored-by: Claude <noreply@anthropic.com>
|
domain:devx#2 · os-justin · session_01QSeKYmTYfaPbLQD4BJfomW 席位核对 — ACCEPT · domain:devx#2 · head
|
Fixes #27700
Clause-②: no
Metadata-protocol: none
维护者速读
docs/design/plugin-distribution.md两处把打包工具写成tsup的句子,改为 esbuild(树形注释一处,§5 第 1 步一处)。os plugin build实际用 esbuild 打包入口到dist/index.mjs,设计说明却指引读者去用tsup。docs/design/plugin-distribution.md第 164 行起的 §5 第 1 步新句子是否与你对构建流程的理解一致。git grep -n -w tsup -- docs/design/plugin-distribution.md,预期没有任何输出。What changes
Two sentences in
docs/design/plugin-distribution.mdnamedtsup;os plugin buildbundles with esbuild. Each replacement is written from whatpackages/cli/src/commands/plugin/build.tsdoes, not by swapping the word:.ospluginlayout, L113): "pre-built ESM bundle (tsup)" becomes "pre-built ESM bundle (esbuild → dist/index.mjs)". The build writes the singledist/index.mjs(outfileand the staged archive entry).tsup(externalize@objectstack/*)" becomes "esbuild-bundle the entry todist/index.mjs(externalize@objectstack/*, inline every other dependency)". In the codeexternal: ['@objectstack/*']is the only external, so every other dependency is inlined; this agrees with §4.3 "Bundled only".Only those two places are edited. The ADR-0025 half of the original card is #27684 (triage re-scope), and
docs/adr/**is untouched.Tests
Docs-only change; no package test applies.
Gate readings
git grep -n -w tsup -- docs/design/plugin-distribution.mdexits 1 with no output (0 hits), against 2 hits onorigin/main2feee8371a.node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstackderived 15 families for this diff; all 15 were run locally and exited 0 (--ranreconciliation: 15 derived, 15 run, 0 NOT-MEASURED). The CI-side families are read from this PR's check-runs.Acceptance notes
skip-changesetis declared at creation:docs/design/is in no package'sfiles[](git grep 'docs/design' -- 'packages/*/package.json'has no hit), so the diff publishes nothing.Verification
git grep -n -w tsup -- docs/design/plugin-distribution.mdprints nothing.Generated by Claude Code