docs(sales): 看板小节按实况重写 + sales/index 补 Account Workbench(#996 #997) - #1000
Merged
Conversation
…list the Sales group's ninth entry (#996 #997) The pipeline page's kanban section carried three claims the metadata contradicts, and the sales index listed eight of the Sales group's nine sidebar entries. #996 — content/docs/sales/pipeline-management.{mdx,zh-Hans.mdx,zh-Hant.mdx} * "7 columns — one per stage": the board declares its own filter, stage not_in [closed_won, closed_lost], so two of the seven stages can never hold a card. The page now states one column per stage, open deals only, five active stages, and says the drawn column count is the console's rendering choice rather than guessing a number. * "Owner avatar" as a fifth card field: cards are bound by kanban.columns, which names four fields. owner_id lives in the view's top-level columns. The list is now four, and the owner is re-pointed to All Opportunities and the Deal Cards gallery, which do carry it. * "The system enforces the stage rules": opportunity_stage_progression is severity 'warning' — the illegal move is logged and saved. The wording now matches administration/state-machines, which has said so all along. * The cadence table's "Open Pipeline Kanban" named nothing in the product; the daily row now sends a reader to the sidebar entry Pipeline. #997 — content/docs/sales/index.{mdx,zh-Hans.mdx,zh-Hant.mdx} * "Where to find things" omitted Account Workbench, an interface page sitting third in the Sales group with a label in every locale bundle. quick-tour.mdx already listed all nine; the two pages disagreed. The section now names it, says what it is, and states the group size. Two guards hold both pages to source in all three locales, because no existing gate opens content/docs: * test/docs-sales-index-navigation.test.ts * test/docs-pipeline-kanban-section.test.ts Docs and tests only — no src/ change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VHrPAGEgFDoHjphqYG4BMa
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
yinlianghui
marked this pull request as ready for review
August 6, 2026 17:39
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #996
Fixes #997
/pm-dispatch R36 并单实施(主单 #996)。行号已在 fresh main(
748002f0)重定位;PR #990 / #994 / #999 的落地行零回退——三份 diff 先读后改,#999 刚落地的 :40 首句、:50/:52 两段、index :63/:64 两条原样保留。三语同步(
en/zh-Hans/zh-Hant),src/零改动,content/docs/releases/未触碰。#996
sales/pipeline-management看板小节① :40「7 columns — one per stage」——按证据边界重写
pipeline_kanban自带过滤器(src/views/opportunity.view.ts),把两个已结束阶段整个排除在外:stagenot_in['closed_won', 'closed_lost']。OPPORTUNITY_STAGE_OPTIONS确有 7 项,但被过滤掉的两个阶段在这块板上永远拿不到一张卡;同处源码注释自述 "keeps all five active stages visible"。证据边界:列究竟由 groupBy 字段的 picklist 选项生成(7 列、其中 2 列恒空)还是由数据生成(5 列),取决于 console 的 kanban 渲染器,不在本仓内。按裁定不断言具体渲染列数,改写为元数据可证的部分:
沿用
content/docs/sales/opportunities.mdx已有的保守口径(「one column per stage, open deals only」,不给数字)。② :42-:46 卡片字段——Owner avatar 是幻影
卡面字段由
kanban.columns决定,只有四个(name/crm_account/amount/close_date);owner_id只在视图顶层columns里。上面那份 console 产物同样印证:cardFields在kanban.columns非空时就取它。清单改为四条,并按 #927 / PR #932 的「说清真名在哪,不要默默删掉」惯例把 Owner 指回真正带它的两处:All Opportunities 的 Owner 列、Deal Cards 图库(
gallery.visibleFields含owner_id)。注意 Open Deals 并没有 Owner 列,故未列入。③ :85(原单写 :86,fresh main 位移一行)Pipeline Kanban 指称
Pipeline Kanban是标识符pipeline_kanban的驼峰读法,产品里没有这个名字。「每日」行改为打开侧边栏条目 Pipeline(zh 作 销售管道 / 銷售管道),与同小节开头 #993 已归位的口径一致。en 页全页已无Pipeline Kanban。④ :48 强制力措辞(原单标「低置信,待核」)——核后改
核实结论:原单的怀疑成立。
opportunity_stage_progression的severity是'warning'(src/objects/opportunity.object.ts),且prospecting的允许集不含closed_won。关键佐证不需要新探针——本仓已有页面把这件事写死过:
content/docs/administration/state-machines.mdx:100明写 "an opportunity can go from Prospecting straight to Closed Won",并说每次这样的写入「writes one warning to the server log and is then saved」;test/status-state-machines.test.ts:68已把五条状态机的severity钉为'warning'。也就是说这一处是两页互相矛盾,而错的是本页。措辞按既有口径统一改为「建议,不是闸门 / advice, not a gate」+「保存照样通过 / the save still goes through」,并链到 State Machines 页(zh 内链不带锚)。
#997
sales/index的《Where to find things》crm.app.ts的group_sales有九个 children,本节只覆盖八个,漏掉第 3 项 Account Workbench(nav_account_workbench,ADR-0047 interface page,zh-CN label 客户工作台,es-ES / ja-JP 语言包同样有真 label)。同一问题getting-started/quick-tour.mdx:53已列全九项、且被 #960 守卫逐项钉死——两页对新读者答案不一致。补法沿本节自身的结构:六个对象入口留在
·那条,三个「打开的不是对象列表」的条目各占一行(Account Workbench 按源码顺序排在 Pipeline 之前),并说明它是什么——复用 All Accounts 视图的列/过滤/排序,加三个快捷筛选(行业、类型、负责人),刻意不提供视图管理与高级过滤,记录与 Accounts 相同。前导句补上分组规模「九个条目」。沿 #932 / #942 / #938 / #927 的导航清单先例。
新增两道守卫(原单 #997 的建议项)
os validate与pnpm lint都不打开content/docs,所以检查必须落在断言所在处(#948 / #960 已写下的理由)。test/docs-sales-index-navigation.test.ts(#997)group_sales;group_sales一致;nav_account_workbench紧跟nav_account且绑account_workbench、该页interfaceConfig复用all_accounts、三份语言包都给了 label。test/docs-pipeline-kanban-section.test.ts(#996)kanban.columns长度严格相等;opportunity_stage_progression;Pipeline Kanban为全页禁);owner_id绑上卡面、拿掉板上的过滤器、把规则提到error,或给 Sales 组加条目,文档都会跟着元数据一起红。反向验证(方向为先判后跑:预测 RED,实测 RED)
git stash push -- content/docs/把六份正文退回 main、只留新守卫:24 条红全部落在读文档的用例上;仍绿的 15 条正是不读文档的 "source facts" 块——方向与预测一致,没有出现空断言式的假绿。恢复正文后 39/39 全绿。
六道门(
flock -w 7200 /tmp/os-heavy-verify.lock内串行,NODE_OPTIONS=--max-old-space-size=4096)pnpm validateData: 17 Objects 344 Fields,仅既有 5 条 author-time 警告pnpm typechecktsc --noEmit无输出pnpm lint13 warning(s), 14 suggestion(s)— 与 main 同pnpm hygiene✓ no raw control bytes in first-party files(扫描面含content/.changeset)pnpm build✓ Build complete,dist/objectstack.json (1921.3 KB)pnpm test -- --maxWorkers=2Test Files 77 passed (77)/Tests 1811 passed | 1 skipped (1812)守卫盲区如实报:#960(
docs-quick-tour-navigation)与 #987 的守卫都不读这两页本面行,单跑确认本次改动不触发它们,predicted GREEN 且实测 GREEN(随全量 77 文件一起绿)。其他
.changeset/sales-pipeline-kanban-section-and-account-workbench.md(站内路径用反引号)。grep -naP对六份 mdx、两份测试与 changeset 做控制字节自扫,结果干净;pnpm hygiene的控制字节门同样绿(扫描面已含content与.changeset)。Sales Copilot在健康信号与节奏表里原样保留,留给 R37 的 Docs drift (round 2 leftovers): ~39 product pages still name "Sales/Service Copilot" as a persona; config comment and RELEASE_STRATEGY.md still stale #612 全站扫。