TDT-2790 Clarify event visibility default is Google-only#333
Open
samLRodrigues wants to merge 1 commit into
Open
TDT-2790 Clarify event visibility default is Google-only#333samLRodrigues wants to merge 1 commit into
samLRodrigues wants to merge 1 commit into
Conversation
The EventVisibility KDoc described DEFAULT/PUBLIC/PRIVATE without noting that Microsoft and EWS accounts reject DEFAULT with a 400 error. Only Google events support DEFAULT. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #333 +/- ##
=========================================
Coverage 83.73% 83.73%
Complexity 486 486
=========================================
Files 44 44
Lines 1359 1359
Branches 115 115
=========================================
Hits 1138 1138
Misses 149 149
Partials 72 72 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates the KDoc for
EventVisibilityinsrc/main/kotlin/com/nylas/models/EventVisibility.ktto note thatDEFAULTonly works for Google events. Microsoft and EWS accounts return a 400 error whenDEFAULTis sent, but the enum docs didn't warn about this.Jira: TDT-2790 (sub-task of TDT-2765)
🤖 Generated with Claude Code