edit filter function added#113
Open
dakshshahani wants to merge 1 commit into
Open
Conversation
Contributor
|
@dakshshahani Saving an edited filter appends it to the end and can change mixed AND/OR logic. Is it possible to make it so that editing a filter edits it in place (track the edited filter ID/index)? Otherwise LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason
Users cannot edit their filters while querying on admin.
Explanation
Allowing users to edit their filters applied to the search on the query tab.
Function updates newFilter states with filter being edited. Function also removed filter being updated.