refactor(conform): notify on error - #2135
Closed
nathanzeng wants to merge 1 commit into
Closed
Conversation
Collaborator
|
I think it is kind of an hack to use the formatter output to know if you have a syntax issue. This is what your lsp and language tools are for. Also most of the time I format out of muscle memory, even if I know there are syntax errors, so I find it kind of annoying. Closing this for now, but if you disagree feel free to open a discussion. If other agree, I will reconsider :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my opinion, we should notify on error by default. This is also the default configuration for conform.
In my usage with conform, I haven't felt that the error noise is an issue. Sometimes it's nice for me when I'm blazing through stuff, I miss the LSP diagnostics, but then when I write I get an error from conform formatter because my syntax tree is broken.