Repository navigation
PowerPoint: report table header rows and columns - #21017
Closed
ChristosBouronikos wants to merge 1 commit into
Closed
ChristosBouronikos wants to merge 1 commit into
ChristosBouronikos wants to merge 1 commit into
Conversation
Every table cell had the role of an ordinary cell. Use the Header Row and First Column table style options to give header cells their roles and to provide the header text of other cells.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #19063
Summary of the issue:
In a PowerPoint table, the options "Header Row" and "First Column" of the table design tab define which cells are headers. NVDA gave every cell the role of an ordinary table cell, so headers were not recognized, and the text of the headers was not reported when moving between the other cells of the table.
Description of user facing changes:
In tables in the PowerPoint editor:
Description of developer facing changes:
None.
Description of development approach:
TableCellcomputed its role as a constant. It now has:role: column header for the first row ifTable.FirstRowis set, otherwise row header for the first column ifTable.FirstColis set, otherwise table cell. The first cell of a table with both options is therefore a column header.rowHeaderTextandcolumnHeaderText: the text of the first cell of the same row or column, for cells which are not themselves a header of that kind, and only when the corresponding option is set. The baseNVDAObjectproperties are used by the existing table reporting code.Testing strategy:
tests/unit/test_appModules/test_powerpnt_tableHeaders.py. The tests cover the roles with both options, the corner cell, both options off, header text from the first row and column, headers having no header of their own kind, and each option being independent. Without the change, they fail.Known issues with pull request:
Code Review Checklist: