feat(playwright): expose _nuxtHooks fixture setup function#899
Open
markbrockhoff wants to merge 1 commit into
Open
feat(playwright): expose _nuxtHooks fixture setup function#899markbrockhoff wants to merge 1 commit into
markbrockhoff wants to merge 1 commit into
Conversation
Contributor
Author
|
Btw: I think the CI pipeline might be broken or flaky as I don't really see a reason why the made change would cause that test to fail on windows and it's failing on main as well ^^' |
markbrockhoff
force-pushed
the
expose-nuxt-hooks-fixture
branch
2 times, most recently
from
July 29, 2024 06:57
f5166fa to
412204b
Compare
markbrockhoff
force-pushed
the
expose-nuxt-hooks-fixture
branch
from
August 14, 2024 07:14
412204b to
5d42df0
Compare
markbrockhoff
force-pushed
the
expose-nuxt-hooks-fixture
branch
from
August 28, 2024 08:12
5d42df0 to
d121d42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I just setup a mock server to mock third party requests made by my nuxt app while running tests with playwright.
In order to redirect those requests to the mock server I overwrote the _nuxtHooks playwright fixture with my own to modify the nuxt config, injecting the url to my mock server into it.
All of this works great but I'd like to keep using the original _nuxtHooks fixture if possible, just modifying the nuxt config passed to it before the app is built.
That's why I extracted it into an exported function so projects can easily modify the nuxt config used for the test app depending on their custom fixtures.
For example like this:
Please let me know what you think :)