fix(e2e): give the tab-seo project a tall viewport so the sidebar dock list doesn't overflow - #1084
Conversation
…k list doesn't overflow The Nuxt group's edge-docked sidebar lists ~20 member docks. At the default 720px viewport height, Devframe's edge-dock toolbar overflows most of them behind a "Show more" popover, and that popover renders underneath the kept-alive devtools iframe (an upstream @devframes/hub-ui stacking bug) — so Playwright's click on an overflowed sidebar item (e.g. Virtual Files, Data Inspector) times out with "iframe intercepts pointer events". Give the tab-seo project's dev/built variants a tall viewport so every member dock renders inline instead, sidestepping the popover (and the bug) entirely. Verified locally: playground-tab-seo.spec.ts's previously-flaky sidebar test now passes consistently (20/20 across 5 runs before this change reliably reproduced the failure).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe Playwright configuration now applies a 1280×2000 viewport to every project. The overflow comment now refers to any dock group. Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change only adjusts the tab-seo end-to-end test viewport to prevent sidebar overflow; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Simplify: no need to gate this per-playground since a 2000px-tall viewport is harmless for the other playgrounds and keeps the config simpler.
What
playground-tab-seo.spec.ts'sleaves the populated Pages dock through the expanded sidebar without emptying the frametest has been failing on everymainpush since it was added (a2c06d22), and is currently red on CI. It clicks sidebar dock buttons (Hooks,Virtual Files,Debug,Data Inspector) that live behind Devframe's "Show more" overflow popover, e.g.:Root cause
The
Nuxtdock group lists ~20 member docks. At the default 1280×720 viewport, Devframe's edge-docked sidebar toolbar only shows a handful before overflowing the rest behind a "Show more" popover. That popover renders underneath the kept-alive devtools iframe (an upstream@devframes/hub-uistacking/z-index issue — confirmed present as far back asdevframe@0.8.0, i.e. unrelated to the recentdevframe/@vitejs/devtoolsbump), so a click on an overflowed item's coordinates hits the iframe instead of the button underneath the popover.Fix
Give the
tab-seoproject (bothdevandbuiltPlaywright projects) a tall viewport (1280x2000) so every one of the group's member docks renders inline in the sidebar, sidestepping the "Show more" popover — and the upstream stacking bug — entirely.Verified locally: ran the previously-flaky test 5x in a row after this change (20/20 clicks across
Hooks/Virtual Files/Debug/Data Inspector, each run) with 0 failures, versus a consistent, reproducible failure before the change. Also ran the fullpnpm test:e2e:devandpnpm test:e2e:builtsuites to confirm no other spec regressed.Note on the other CI failure
ci's "Release Nightly" step (pnpm publishof@nuxt/devtools-assets-nightly) has also been failing with a registry404on everymainpush since the@nuxt/devtools-assetspackage was introduced (39470fd1) — this is a one-time npm registry/token permission issue for a package that's never been successfully published (OIDC trusted-publish falls back to the token-based publish, which also 404s), not something fixable from a source change. It needs an npm org admin to grant the CI token/OIDC publisher access to the new package name. Left untouched here since it's out of scope for a code PR.This PR was created with the help of an AI agent.