Repository navigation
Find a .nupkg's dependencies in the packages folder for enum defaults - #112
Merged
Merged
Conversation
A .nupkg read on its own now looks for its dependencies, and theirs, in the packages folder restore fills (~/.nuget/packages, or NUGET_PACKAGES), at the version restore would pick: the lowest the range allows, among the versions restore finished. Nothing is downloaded; a dependency that is not there leaves its enums as casts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #111. A
.nupkgread on its own (assembly-differ api MyLib.1.2.0.nupkg) wrote an enum default from a dependency as a cast unless-rnamed the folder. It now finds its dependencies itself:~/.nuget/packages,NUGET_PACKAGES, or what NuGet.config says..nupkg.metadatapresent).ref/assemblies when it has them, otherwiselib/, for the nearest framework.-rstill adds folders on top.Verified:
A_package_finds_its_dependencies_in_the_packages_folderpacks a real project whose package declares the enum:Mode.Auto;(Mode)5, with no error.A_package_takes_the_version_restore_would_through_its_dependencies_dependenciesuses a hand-made packages folder:Usesdepends onMiddle, which depends onModes [1.1.0, );Modesis there at 1.0.0, at 1.1.0 with an unfinished restore, at 1.2.0 and at 2.0.0, and each declares value 5 under a different name;mise run ciis green locally.🤖 Generated with Claude Code