Distributed multi-shard query#3759
Merged
Merged
Conversation
jotare
force-pushed
the
multi-shard-search-2
branch
from
0cfc8d9 to
a9907c0
Compare
javitonino
reviewed
Jul 1, 2026
| } | ||
|
|
||
| let mut tasks = JoinSet::new(); | ||
| for (node, shard_ids) in shard_groups { |
Contributor
There was a problem hiding this comment.
I'm getting lost reading this function since it's quite long and nested. Maybe the contents of this loop can be extracted?
Contributor
Author
There was a problem hiding this comment.
I'm not sure extracting the whole loop would make it more readable. I'll see what I can do
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The next step towards moving multi-shard querying to Rust. This PR implements forwarding of search requests with grouped shards between nidx-searcher nodes
How was this PR tested?
New integration tests