Repository navigation
Dividers in bins (F18): one center divider in every generated bin STL - #159
Merged
Merged
Conversation
…#159) Bin options switch adds a 1.2 mm divider down the middle of each bin's long side, from the bin floor up to the top of the bin units, below the stacking lip so bins still stack. Persisted as gridfinity_dividers, local-only, not in share links. Estimates include the divider volume; the Download files README notes it. Feature map: F18 not present to partial, parity 49.0% to 50.0%.
✅ Deploy Preview for gridfinity-drawer-planner ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
PR Quality Report 📊
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
=======================================
Coverage ? 93.99%
=======================================
Files ? 71
Lines ? 3644
Branches ? 1067
=======================================
Hits ? 3425
Misses ? 198
Partials ? 21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dividers in bins (F18): one center divider in every generated bin STL
Bin options gains a "Dividers in bins" switch. When on, every generated bin STL gains one center divider down the middle of its long side (square bins: along x), 1.2 mm thick, from the bin floor up to the top of the bin units, below the stacking lip so bins still stack. Persisted as
gridfinity_dividers, local-only (not in share links, same precedent as label tabs and test fit). Estimates include the divider volume; the Download files README notes it. The divider changes neither part height nor footprint, so 3MF plate packing and the printer-Z limit are untouched.Feature map: F18 ❌→🟡 (one fixed divider, not configurable counts or positions), parity 49.0% → 50.0% (23 ✅ + 4 🟡 / 50). F15 cell wording updated (dividers no longer in its missing list).
Evidence
npm test51 files, 603 passed / 11 skipped;npm run lintclean;npx tsc --noEmitclean;npm run buildgreen (index chunk 236,207 → 237,001 B, +0.3%; lazy export chunk 22,147 → 22,830 B, +3.1%).node scripts/measure.mjs --n=15 --lh=3× 2 pairs (branch then trunk; trunk then branch): branch LH 73/71, TTI 3630/3772 ms, input-to-preview 62.5/43.7 ms, layout 562/515 ms, share 113/93 ms; trunk LH 72/65, TTI 3696/4127 ms, input-to-preview 38.4/47.2 ms, layout 558/509 ms, share 91/90 ms. Verdict: no credible regression — pair 1's interaction gaps did not reproduce in the reversed pair, and trunk's own swing exceeds every branch–trunk gap. The diff touches no measured code path.Scoreboard
docs/scoreboard.mdupdated with the 2026-10-30 section (parity 50.0%, both perf pairs, bundle delta).