Repository navigation
Conversation
End-rey
requested review from
carpawell,
cthulhu-rider and
roman-khimov
as code owners
November 11, 2026 08:22
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4302 +/- ##
==========================================
+ Coverage 32.71% 32.82% +0.10%
==========================================
Files 673 673
Lines 41701 41708 +7
==========================================
+ Hits 13644 13690 +46
+ Misses 28057 28018 -39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Skip SEARCH and DELETE eACL rules requiring unavailable object attributes instead of treating them as absent. Continue evaluating subsequent rules. Closes #4296. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Include address headers when checking SearchV2 requests so object filters can match the requested container ID. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
End-rey
force-pushed
the
4296-eacl-unavailable-attributes
branch
from
November 11, 2026 08:32
89fde5c to
4af9b13
Compare
Register cleanup in both TestErrorReporting subtests to stop background
GC before their test loggers become invalid. Otherwise GC can log after
a subtest completes and panic during subsequent tests.
```
panic: Log in goroutine after TestErrorReporting/ignore_errors_by_default has completed: 2026-11-11T08:35:27.396Z DEBUG started expired objects handling {"shard_id": "PQsradCGbmrg4kiknznTtg", "epoch": 0}
[recovered, repanicked]
```
Signed-off-by: Andrey Butusov <andrey@nspcc.io>
| if reqInfo.Operation == acl.OpObjectSearch || reqInfo.Operation == acl.OpObjectDelete { | ||
| // Object attributes are unavailable for these operations, not absent. | ||
| // Skip rules requiring them so NOT_PRESENT cannot match spuriously. | ||
| table.SetRecords(slices.DeleteFunc(slices.Clone(table.Records()), func(r eacl.Record) bool { |
Member
There was a problem hiding this comment.
Seems very dangerous to me, EACL table shouldn't be mangled. Likely there are other ways to fix it.
Contributor
Author
There was a problem hiding this comment.
Agreed, I'll move the fix to the SDK validator so the eACL table stays intact.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4296.