Repository navigation
policer: break infinite recursion of EC parts restoration - #4293
Merged
roman-khimov merged 1 commit intoNov 11, 2026
Merged
Conversation
carpawell
requested review from
End-rey,
cthulhu-rider and
roman-khimov
as code owners
November 9, 2026 16:01
carpawell
force-pushed
the
fix/infinite-recursion-in-ec-parts-restoration
branch
2 times, most recently
from
November 9, 2026 16:02
f9bc726 to
0729eaa
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4293 +/- ##
==========================================
+ Coverage 32.72% 32.78% +0.05%
==========================================
Files 673 673
Lines 41707 41707
==========================================
+ Hits 13647 13672 +25
+ Misses 28060 28035 -25 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
End-rey
approved these changes
Nov 9, 2026
roman-khimov
left a comment
roman-khimov
left a comment
Member
There was a problem hiding this comment.
Add a test and rebase, please.
Refs. GHSA-3qjg-8x3j-679r
An error from e8d0383. In some rare cases it is possible to restore EC parts from more than a single EC rule, `initialRuleIdx` was meant to break EC rules loop in fully unavailable cases and not try to check EC rules infinitely. Reported-by: Fabian Wahle <fabian@nash.io> Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
carpawell
force-pushed
the
fix/infinite-recursion-in-ec-parts-restoration
branch
from
November 11, 2026 10:42
0729eaa to
d2f6451
Compare
roman-khimov
approved these changes
Nov 11, 2026
roman-khimov
deleted the
fix/infinite-recursion-in-ec-parts-restoration
branch
November 11, 2026 11:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An error from e8d0383. In some rare cases it is possible to restore EC parts from more than a single EC rule,
initialRuleIdxwas meant to break EC rules loop in fully unavailable cases and not try to check EC rules infinitely.