Repository navigation
Conversation
The swipe measured the fingers' speed and let it go stale with time.Now, while the ring's springs and the headless model's events run on the graph's clock. A test's swipe could fling one card further or not depending on how long the machine took between events (#326). It now reads Scope.Now, which is the system's clock in an app and the test's manual clock headless.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Ref in unplaced Holder content could send focus, blur or scroll commands for a view that had never been created. A mount effect could also queue a scroll for a view removed before the same commit. Both paths crashed the headless model, and Apple backends indexed missing views without checking them.
Focus and scroll requests now require placed content. Commit preparation drops commands for deleted or unavailable targets regardless of view pacing, and still creates waiting views before valid commands. Dropping an unsent scroll restores its predicted offset and acknowledgement count. Detached lists discard imperative requests while retaining their initial position; retained web/native views keep accepting their background commands.
The headless model reports an invalid mount item's symbolic kind and view ID, with a separate diagnostic for a missing insertion parent. macOS and iOS ignore missing-view items. Android consumes and ignores missing-target focus/blur/scroll/zoom requests; its checked-in dex and jar were rebuilt with
internal/platform/android/runtime/build.sh. Windows, Linux, web, watchOS and mini-program receivers already guard these lookups.Regression tests cover pacing on/off, previously created and never-created held content, no replay after placement, deletion within an update, creation before a paced command, scroll acknowledgements, initial list positioning, retained web commands, malformed model batches, and malformed native AppKit batches. Public focus documentation and the app-authoring reference describe the drop behavior.
The branch also includes two existing baseline repairs exposed by the complete local suite: the gallery terminal test uses a plain shell, and Orbit measures swipes on the app clock. Both are separate commits, also present in #351.
Validation on rebased head
640fd172:go tool nsgo check -target all: all 14 targets passed.go tool nsgo test: 2240 passed, 0 failed, 16 skipped.TestMountIgnoresCommandsForMissingViews: passed.go tool nsgo test -run '^TestASwipe' examples/orbit -- -count=10: both swipe tests passed all 10 repetitions (20 passes).internal/platform/android/runtime/build.sh.git diff --check: passed.Closes #285.