fix: prevent source map references from being resolved - #3220
fix: prevent source map references from being resolved#3220golden-fox07 wants to merge 2 commits into
Conversation
Thanks for opening this pull request! 🎉We really appreciate you taking the time to contribute, @golden-fox07. A maintainer will take a look as soon as they can. In the meantime, please make sure that:
If anything needs adjusting we'll leave comments here. Thanks again! |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughChangesDocumentation resolver
Merge Risk: ⚪ Minimal · up to The resolver now leaves source map references unchanged, preventing unnecessary failed requests without changing normal documentation output. No actionable merge-blocking risk remains beyond normal checks. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
🔗 Linked issue
Resolves: #2739
🧭 Context
index.d.ts.mapwas getting treated as a package name because it didnt start with .📚 Description
.mapreferences are now skipped by the resolver.d.ts.mapfiles anywayOpen Question
I put the check in the resolver since thats where the misclassification happens. It relies on
createLoaderignoring non http(s) urls though.mapskip in the loader too?