Skip to content

docs: describe current shell execution and notice logging - #282

Closed
xiehuanyi wants to merge 1 commit into
npm:mainfrom
xiehuanyi:docs/current-shell-execution
Closed

xiehuanyi wants to merge 1 commit into
npm:mainfrom
xiehuanyi:docs/current-shell-execution

Conversation

@xiehuanyi

Copy link
Copy Markdown

Correct the README's execution path: run-script passes the package command and extra arguments to @npmcli/promise-spawn, whose shell-specific escaping runs the resulting command directly. Replace the nonexistent local lib/escape.js pointer with the dependency's source link and describe the actual proc-log.log.notice channel for inherited-stdio messages.

Validation: real lifecycle calls confirmed literal extra arguments containing spaces, quotes, and semicolons, shell operators in package scripts, and the notice/run logging event. The new source link exists. npm test passed with 100% coverage, ESLint, and template checks. Documentation only; AI-assisted with OpenAI Codex.

@xiehuanyi
xiehuanyi requested a review from a team as a code owner October 7, 2026 10:49
Copilot AI balanced review requested due to automatic review settings October 7, 2026 10:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@xiehuanyi xiehuanyi closed this Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants