Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
promiseSpawn.execve(cmd, args, opts)andpromiseSpawn.canExecve().execve()builds the command exactly like the shell branch ofpromiseSpawn()(sameescape.shquoting, sameopts.shell/opts.env/opts.cwdhandling), but instead of spawning a child it replaces the current process withprocess.execve().Before handing over it flushes stdout/stderr and puts stdio back into blocking mode.
The latter is a workaround for nodejs/node#66824:
process.execve()passes stdio on inO_NONBLOCK, so programs that expect blocking writes fail withEAGAINas soon as a pipe buffer fills up.Setting the mode again is a no-op once Node.js fixes this itself.
canExecve()is false on Windows, whereprocess.execve()does not exist; callers use it to fall back topromiseSpawn().This is the building block for npm/cli#10165 (
npxkeeping an idle npm process alive for the whole lifetime of the command).Follow-ups: npm/run-script#283 and npm/cli#10166.
Tested with the full suite (100 % coverage) on Node.js 22, 24 and 26.