fix: include shared production dependencies in sbom output - #9936
Open
rootsec1 wants to merge 1 commit into
Open
fix: include shared production dependencies in sbom output#9936rootsec1 wants to merge 1 commit into
rootsec1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm sbom --omit=devcan omit an installed package that is used by both a production dependency and a root dev dependency. The dependency-type selector removes the package because of the dev reference even though it is still required by the production tree.Use Arborist's existing
Node.shouldOmit()logic after selecting the nodes instead. This keeps packages that have a non-omitted dependency path while continuing to exclude packages used only by omitted dependency types. Workspace filtering and SBOM formatting remain unchanged.The regression test covers a hoisted package shared by a production dependency and a root dev dependency.
node . testand the lint checks pass.Closes #7909