Skip image push on fork pull requests#117
Open
laritakr wants to merge 1 commit into
Open
Conversation
The build workflow now pushes images only for same-repo events, so a pull request from a fork builds each image to validate it but does not attempt the registry push.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Needed for: samvera-labs/hyku_knapsack#53
Details
GITHUB_TOKENthat cannot write organization packages. The build step pushed images unconditionally, so on a fork PR the push was denied, the build job failed, and the matrix fail-fast cancelled the remaining jobs (test and lint never ran).pushjob is skipped under the same condition, since a fork PR produces no per-arch tags to assemble.workflow_dispatchare unaffected — they push exactly as before.