Repository navigation
fix(site): start the cards on time with Huginn's fly-in - #14
Merged
Merged
Conversation
The second card could take over 10 s to appear on the home page. Huginn's flight does not cross it for 5 to 6 s, and its sweep could then run for another 5 s. Sweeps now last 0.6 to 1 s. The first card still starts as he reaches it, and the second always starts 0.6 s after the first, so the two keep the same timing against him on every load. His flight is unchanged. The safety timer for a stalled worker now runs from page load, at 8 s.
craig-o-curtis
approved these changes
Oct 31, 2026
craig-o-curtis
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks. The cards now come in on time and the flight is untouched.
A few small things, none blocking:
i === 2 && painted[1]assumes the order header, card 1, card 2. The raven code already treats index 1 as the card, but named constants (or a "each card follows the one before" rule) would keep this from breaking if a third card is added.- Boxes he never reaches used to follow 1.1 s after the last one; now they wait for the end of the fly-in, with the 8 s timer as the backstop. Fine on the loads measured, just worth knowing.
- The commit message says the second card could take "over 10 s"; the description says 5 to 6 s.
Contributor
Author
|
Thanks @craig-o-curtis. On your three notes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The second card on the home page took about 5 to 6 s to be fully visible, and its timing looked unrelated to Huginn. His flight does not reach that card until 5 to 6 s after load, so it usually started from a fallback 1.1 s after the previous pane, and its sweep could then run for up to 5 s.
What changed
SECOND_CARD_FOLLOWS), so the two keep the same timing against him on every load.aurora.raven.tsis untouched, so his flight is the same as before. The sweep still runs in the direction he flies.Timing
Production build on an Apple M1 Pro GPU, in headless Chromium. Times are seconds after page load.
In the 6 desktop dev-server loads where I compared the two, the first card started 0.10 to 0.13 s before his body touched it.
Limits
Checks
pnpm lint,pnpm format:check,pnpm checkandpnpm buildall pass. Timing was measured with a throwaway script; nothing was added to the repo's tests.