Skip to content

fix: reap idle HTTP/2 sessions#5406

Merged
metcoder95 merged 1 commit into
mainfrom
fix-h2-idle-keepalive-timeout
Jun 12, 2026
Merged

fix: reap idle HTTP/2 sessions#5406
metcoder95 merged 1 commit into
mainfrom
fix-h2-idle-keepalive-timeout

Conversation

@mcollina

@mcollina mcollina commented Jun 9, 2026

Copy link
Copy Markdown
Member

Summary

Fixes: #5381

Tests

  • npx borp -p test/issue-5381.js
  • npx borp -p "test/http2-*.js"
  • npm run lint -- --fix-dry-run

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.72131% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.24%. Comparing base (ee59da3) to head (812ff07).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
lib/dispatcher/client-h2.js 96.72% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5406      +/-   ##
==========================================
- Coverage   93.25%   93.24%   -0.01%     
==========================================
  Files         110      110              
  Lines       36752    36885     +133     
==========================================
+ Hits        34274    34395     +121     
- Misses       2478     2490      +12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@metcoder95 metcoder95 merged commit c972895 into main Jun 12, 2026
38 checks passed
@metcoder95 metcoder95 deleted the fix-h2-idle-keepalive-timeout branch June 12, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTTP/2 sessions are never idle-reaped: keepAliveTimeout has no effect when h2 is negotiated (default since v8)

3 participants