Repository navigation
quic: do not reset streams when destroying with a close code - #67349
Open
manusingh090 wants to merge 1 commit into
Open
manusingh090 wants to merge 1 commit into
manusingh090 wants to merge 1 commit into
Conversation
session.destroy() with a close code sends a CONNECTION_CLOSE, which ends every open stream along with the connection (RFC 9000, Section 10.2). Destroying each stream first sent a RESET_STREAM (and, with an error, STOP_SENDING) for it, so the peer saw its streams fail with an unrelated error code before it learned how the session closed. Skip the per-stream frames while the session is ending its streams with a CONNECTION_CLOSE, either from destroy() with a close code or from an immediate close in the native layer. Fixes: nodejs#67278 Assisted-by: a coding agent Signed-off-by: Manjeet Singh <024manjeetsingh@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
session.destroy() with a close code sends a CONNECTION_CLOSE, which ends every open stream along with the connection (RFC 9000, Section 10.2). Destroying each stream first sent a RESET_STREAM (and, with an error, STOP_SENDING) for it, so the peer saw its streams fail with an unrelated error code before it learned how the session closed.
Skip the per-stream frames while the session is ending its streams with a CONNECTION_CLOSE, either from destroy() with a close code or from an immediate close in the native layer.
Fixes: #67278
Assisted-by: a coding agent