Skip to content

test: use relative paths within test directory in test-watch-mode.mjs #67343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LiviaMedeiros wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: use relative paths within test directory in test-watch-mode.mjs #67343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions test/sequential/test-watch-mode.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import * as common from '../common/index.mjs';
import tmpdir from '../common/tmpdir.js';
import assert from 'node:assert';
import os from 'node:os';
import path from 'node:path';
import { execPath } from 'node:process';
import { describe, it } from 'node:test';
Expand Down Expand Up @@ -307,7 +306,7 @@ describe('watch mode', { concurrency: !process.env.TEST_PARALLEL, timeout: 60_00
it('should not crash when --env-file-if-exists points to a missing file', async () => {
const envKey = `TEST_ENV_${Date.now()}`;
const jsFile = createTmpFile(`console.log('ENV: ' + process.env.${envKey});`);
const missingEnvFile = path.join(tmpdir.path, `missing-${Date.now()}.env`);
const missingEnvFile = tmpdir.resolve(`missing-${Date.now()}.env`);
const { done, restart } = runInBackground({
args: ['--watch-path', tmpdir.path, `--env-file-if-exists=${missingEnvFile}`, jsFile],
});
Expand Down Expand Up @@ -1091,19 +1090,18 @@ process.on('message', (message) => {
// Honoring --require from NODE_OPTIONS is required for this test.
skip: !!process.config.variables.node_without_node_options,
}, async () => {
// Use /tmp to avoid CI directories with special characters (e.g. ")
// Use relative path to avoid CI directories with special characters (e.g. ")
// that would break NODE_OPTIONS parsing.
const watchDir = path.join(os.tmpdir(), 'test for --watch parsing');
mkdirSync(watchDir, { recursive: true });
const reqFile = path.join(watchDir, 'req.cjs');
const reqFile = tmpdir.resolve('req.cjs');
writeFileSync(reqFile, 'globalThis.requiredOk = true;');

const file = createTmpFile('console.log("required:" + !!globalThis.requiredOk);');
// Backslashes inside quoted NODE_OPTIONS values are escape characters.
const nodeOptions = `--watch --require "${reqFile.replaceAll(path.sep, '/')}"`;
const nodeOptions = '--watch --require ./req.cjs';
const { done, restart } = runInBackground({
args: ['--watch', file],
options: {
cwd: tmpdir.path,
env: { ...process.env, NODE_OPTIONS: nodeOptions },
},
});
Expand Down Expand Up @@ -1168,16 +1166,17 @@ process.on('message', (message) => {

it('should strip multiple --watch-path entries from NODE_OPTIONS', async () => {
const file = createTmpFile('console.log(process.env.NODE_OPTIONS);');
// Use /tmp to avoid CI directories with special characters (e.g. ")
// Use relative path to avoid CI directories with special characters (e.g. ")
// that would break NODE_OPTIONS parsing.
const dirA = path.join(os.tmpdir(), 'node-watch-path-a');
const dirB = path.join(os.tmpdir(), 'node-watch-path-b');
const dirA = tmpdir.resolve('node-watch-path-a');
const dirB = tmpdir.resolve('node-watch-path-b');
mkdirSync(dirA, { recursive: true });
mkdirSync(dirB, { recursive: true });
const nodeOptions = `--watch --watch-path=${dirA} --watch-path ${dirB} --no-warnings`;
const nodeOptions = '--watch --watch-path=./node-watch-path-a --watch-path ./node-watch-path-b --no-warnings';
const { done, restart } = runInBackground({
args: ['--watch', file],
options: {
cwd: tmpdir.path,
env: { ...process.env, NODE_OPTIONS: nodeOptions },
},
});
Expand Down
Loading