Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/internal/test_runner/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -768,7 +768,7 @@ class Test extends AsyncResource {
this.expectedAssertions = plan;
this.cancelled = false;
this.expectFailure = parseExpectFailure(expectFailure) || this.parent?.expectFailure;
this.skipped = skip !== undefined && skip !== false;
this.skipped = !!skip;
this.isTodo = (todo !== undefined && todo !== false) || this.parent?.isTodo;
this.startTime = null;
this.endTime = null;
Expand Down
22 changes: 22 additions & 0 deletions test/parallel/test-runner-skip-falsy.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
'use strict';
const common = require('../common');
const assert = require('node:assert');
const { run, suite, test } = require('node:test');

// The skip option is documented as a truthy check, so falsy values other than
// false and undefined must run the test and not report it as skipped.
const falsyValues = ['', 0, null, NaN];

if (!process.env.NODE_TEST_CONTEXT) {
const stream = run({ files: [__filename] });

stream.on('test:fail', common.mustNotCall());
stream.on('test:pass', common.mustCall((event) => {
assert.strictEqual(event.skip, undefined);
}, falsyValues.length * 2));
} else {
for (const value of falsyValues) {
test(`test skip: ${value}`, { skip: value }, common.mustCall());
suite(`suite skip: ${value}`, { skip: value }, common.mustCall());
}
}
Loading