Repository navigation
test: deflake test-worker-eventlooputil - #67260
Merged
nodejs-github-bot merged 1 commit intoNov 8, 2026
Merged
Conversation
worker.performance.eventLoopUtilization() reads the worker's idle time before the current time. If the parent thread stalls between the two reads while the worker is idle, the stall is counted as worker active time in the first sample and is missing from the delta, so the 50ms spin can be reported as slightly less than 50ms. Bound that skew by timing the first workerELU() call. Signed-off-by: Matteo Collina <hello@matteocollina.com>
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67260 +/- ##
==========================================
+ Coverage 90.65% 90.66% +0.01%
==========================================
Files 797 797
Lines 278268 279367 +1099
Branches 53517 53735 +218
==========================================
+ Hits 252261 253291 +1030
+ Misses 16386 16360 -26
- Partials 9621 9716 +95 🚀 New features to boost your workflow:
|
ronag
approved these changes
Nov 8, 2026
mcollina
added
the
request-ci
UlisesGascon
approved these changes
Nov 8, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
panva
added
the
flaky-test
mcollina
added
the
commit-queue
Collaborator
|
Landed in 768315c |
nodejs-github-bot
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
worker.performance.eventLoopUtilization() reads the worker's idle time
before the current time. If the parent thread stalls between the two
reads while the worker is idle, the stall is counted as worker active
time in the first sample and is missing from the delta, so the 50ms
spin can be reported as slightly less than 50ms:
Injecting a 2ms busy-wait between the two reads reproduces it every time
(
active=48.05). The test now bounds the skew by timing the firstworkerELU()call.Refs: nodejs/reliability#1482
AI Generated, reviewed by me