Skip to content

quic: fix internal error code conversion - #66967

Open
efekrskl wants to merge 2 commits into
nodejs:mainfrom
efekrskl:quic/fix-internal-error-code
Open

efekrskl wants to merge 2 commits into
nodejs:mainfrom
efekrskl:quic/fix-internal-error-code

Conversation

@efekrskl

Copy link
Copy Markdown
Member

Two internal failure paths passed error NGTCP2_INTERNAL_ERROR where an ngtcp2 library error was expected, causing it to fall back to PROTOCOL_VIOLATION.

Use NGTCP2_ERR_INTERNAL so these failures are correctly reported as INTERNAL_ERROR.

Signed-off-by: Efe Karasakal <hi@efe.dev>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC transport implementation. labels Oct 23, 2026
Signed-off-by: Efe Karasakal <hi@efe.dev>
@codecov

codecov Bot commented Oct 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.58%. Comparing base (6511fb8) to head (dcc3a67).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66967      +/-   ##
==========================================
- Coverage   90.59%   90.58%   -0.01%     
==========================================
  Files         797      797              
  Lines      278293   278293              
  Branches    53520    53517       -3     
==========================================
- Hits       252112   252089      -23     
- Misses      16563    16572       +9     
- Partials     9618     9632      +14     

see 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC transport implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants