Repository navigation
tls: test the SPKI blocklist with a fixture key - #66949
Open
UlisesGascon wants to merge 1 commit into
Open
UlisesGascon wants to merge 1 commit into
UlisesGascon wants to merge 1 commit into
Conversation
Replace the test-only hooks on the crypto binding, and the process-wide list and mutex they required on every handshake, with a fixture CA whose public key is a permanent entry on the compiled-in blocklist. The test now exercises the real list through full handshakes, without --expose-internals, and the production path is a comparison against a constant array. The new fixtures provide two chains that contain the blocked key: a server certificate issued by blocked-ca, and one issued by ca1 that reuses the blocked key itself. The private key is checked in like every other fixture key, so blocking it costs nothing. It is pinned in the fixtures Makefile, since its digest is compiled in. Refs: nodejs#66871 (comment) Assisted-by: Claude, Codex Signed-off-by: Ulises Gascon <ulisesgascongonzalez@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
UlisesGascon
marked this pull request as ready for review
October 23, 2026 09:47
UlisesGascon
commented
Oct 23, 2026
Comment on lines
+1438
to
+1447
| // Test fixture, not a real CA: test/fixtures/keys/blocked-ca-key.pem. | ||
| // Its private key is public, so blocking it costs nothing and lets | ||
| // test/parallel/test-tls-spki-blocklist.js exercise the real list. The | ||
| // key is pinned in the fixtures Makefile; rotating it means updating | ||
| // this entry too. | ||
| // a6cbb923961eada55c02f104681aeabe52ea1508ece2078aec11d00a5778ce71 | ||
| // C=US, ST=CA, L=SF, O=Joyent, OU=Node.js, CN=blocked-ca | ||
| {0x41, 0xc2, 0xd1, 0xc4, 0x24, 0x68, 0x46, 0x6a, 0x54, 0x24, 0x83, | ||
| 0x69, 0xf6, 0x65, 0x9a, 0x95, 0x52, 0xc5, 0xa4, 0x16, 0xf8, 0xd5, | ||
| 0xfc, 0xd8, 0xdd, 0x55, 0xa8, 0x75, 0xd7, 0x20, 0xaa, 0xc2}, |
Member
Author
There was a problem hiding this comment.
hey @pimterry! Not sure if this is the correct approach for the refactor, happy to explore other ideas 🤔
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66949 +/- ##
==========================================
- Coverage 92.93% 90.59% -2.34%
==========================================
Files 428 797 +369
Lines 195236 278292 +83056
Branches 30189 53509 +23320
==========================================
+ Hits 181438 252115 +70677
- Misses 13471 16555 +3084
- Partials 327 9622 +9295
🚀 New features to boost your workflow:
|
pimterry
added
the
request-ci
github-actions
Bot
removed
the
request-ci
panva
added
the
author ready
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the test-only hooks on the crypto binding, and the process-wide list and mutex they required on every handshake, with a fixture CA whose public key is a permanent entry on the compiled-in blocklist. The test now exercises the real list through full handshakes, without --expose-internals, and the production path is a comparison against a constant array.
The new fixtures provide two chains that contain the blocked key: a server certificate issued by blocked-ca, and one issued by ca1 that reuses the blocked key itself. The private key is checked in like every other fixture key, so blocking it costs nothing. It is pinned in the fixtures Makefile, since its digest is compiled in.
Refs: #66871 (comment)
Assisted-by: Claude, Codex