stream: apply multiple stream/iter fixes - #65652
Open
jasnell wants to merge 11 commits into
Open
Conversation
Collaborator
|
Review requested:
|
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #65652 +/- ##
==========================================
- Coverage 90.06% 90.05% -0.01%
==========================================
Files 754 754
Lines 255747 256005 +258
Branches 48318 48390 +72
==========================================
+ Hits 230327 230544 +217
- Misses 16550 16564 +14
- Partials 8870 8897 +27
🚀 New features to boost your workflow:
|
Collaborator
trivikr
requested changes
Aug 30, 2026
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
jasnell
force-pushed
the
jasnell/stream-iter-fixes
branch
from
August 30, 2026 19:55
23b211e to
06d1687
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nine commits, nine issues:
pull()cancellation cannot preempt a pendingnext()writer.end()hang foreverwritev()can resolve after losing the entire outer writeclose()does not close an unread incoming directionmerge()mishandles arbitrary errors and can block error propagation foreverpipeToSync()starts asynchronous close work that nobody can observeRecommend reviewing each commit separately.
Plus one minor cleanup commit.