build: enable -fvisibility to improve startup speeds - #65526
Open
avivkeller wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
Signed-off-by: avivkeller <me@aviv.sh>
avivkeller
force-pushed
the
improve-startup
branch
from
August 25, 2026 04:44
25d6c9c to
349d171
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65526 +/- ##
=======================================
Coverage 90.13% 90.14%
=======================================
Files 751 751
Lines 253656 253679 +23
Branches 47787 47788 +1
=======================================
+ Hits 228631 228668 +37
- Misses 16258 16266 +8
+ Partials 8767 8745 -22
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @joyeecheung this resolves your
TODO(joyeecheung): investigate if it breaks addons.comment.If I understand correctly, this is fine to enable, since:
signo_string). Weak symbols don't matter here.Plus, it speeds up startups by ~33% (yay!):
Running JS (
--eval)--versionOnly