quic: apply multiple fixes to flow control signaling - #65309
Open
jasnell wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65309 +/- ##
==========================================
- Coverage 90.14% 90.12% -0.03%
==========================================
Files 751 751
Lines 253656 253694 +38
Branches 47776 47786 +10
==========================================
- Hits 228662 228640 -22
- Misses 16256 16322 +66
+ Partials 8738 8732 -6
🚀 New features to boost your workflow:
|
Collaborator
Contributor
|
Great addition to find more stalls in the pipeline. |
Collaborator
Member
Author
|
@pimterry @Ethan-Arrowood @nodejs/quic ... really need to get this landed before we muck around with more of the quic impl |
jasnell
force-pushed
the
jasnell/quic-flow-control-fixes
branch
from
August 25, 2026 02:50
b5be01b to
242734c
Compare
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode/Opus
jasnell
force-pushed
the
jasnell/quic-flow-control-fixes
branch
from
August 25, 2026 02:51
242734c to
d889ee8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing up the QUIC flow control signaling and closed stream handling, expand tests.
Update the flow control handling after the iter streams byte-budget based flow control updates.
@nodejs/quic @pimterry @martenrichter