stream: skip null output from stateful transforms#64462
Open
trivikr wants to merge 1 commit into
Open
Conversation
Treat null yielded by sync and async stateful transforms as no output, consistent with transform normalization semantics. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Collaborator
|
Review requested:
|
jasnell
approved these changes
Jul 12, 2026
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64462 +/- ##
==========================================
+ Coverage 90.23% 90.24% +0.01%
==========================================
Files 741 741
Lines 241375 241606 +231
Branches 45483 45536 +53
==========================================
+ Hits 217800 218036 +236
+ Misses 15129 15109 -20
- Partials 8446 8461 +15
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64461
Stateful transforms currently pass
nulloutput to the flatteninghelpers, causing
ERR_INVALID_ARG_TYPE. Transform outputnormalization defines
nullas no output.Skip
nullbefore flattening stateful transform output in both thesync and async paths.