test_runner: report changed file on watch restart#64457
Open
bitpshr wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
The `test:watch:restarted` reporter event now includes a `file` property with the path of the file whose change triggered the restart. The watcher already surfaces this path through the `changed` event since it started printing the changed file name, so this just forwards it to consumers of the reporter stream. Fixes: nodejs#63786 Signed-off-by: Paul Bouchon <mail@bitpshr.net>
nodejs-github-bot
added
needs-ci
bitpshr
force-pushed
the
test-runner/watch-restarted-file
branch
from
9c65306 to
7871ade
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This picks up #63786 and adds a
fileproperty to thetest:watch:restartedreporter event, so custom reporters can show which file triggered the restart.The watcher already carries that path on its
changedevent since #63781, so this mostly just forwards it along. I typed it as{string|undefined}to matchtest:summary'sfile, and it'sundefinedwhen the triggering file can't be determined. Since the event had no data before, this stays backward-compatible.I kept the change to the event data so the default spec reporter output is unchanged, but I'm happy to surface the file there too if that seems useful.
Fixes: #63786