test_runner: remove unused shuffleArrayWithSeed#63847
Open
watilde wants to merge 1 commit into
Open
Conversation
shuffleArrayWithSeed was introduced along with test order randomization but was never called: the feature picks a random pending subtest at dequeue time using createSeededGenerator directly. Remove the dead helper and its export, and add direct unit coverage for createSeededGenerator's deterministic contract. Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
atlowChemi
approved these changes
Jun 11, 2026
atlowChemi
added
author ready
JakobJingleheimer
approved these changes
Jun 11, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shuffleArrayWithSeed was introduced along with test order randomization but was never called: the feature picks a random pending subtest at dequeue time using createSeededGenerator directly. Remove the dead helper and its export, and add direct unit coverage for createSeededGenerator's deterministic contract.