assert: fix Assert instance diff option ignored in throws/rejects#63840
Open
Anshikakalpana wants to merge 1 commit into
Open
assert: fix Assert instance diff option ignored in throws/rejects#63840Anshikakalpana wants to merge 1 commit into
Anshikakalpana wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
assert
Anshikakalpana
force-pushed
the
fix-assert-diff-context
branch
3 times, most recently
from
89a7751 to
f533b10
Compare
Signed-off-by: anshikakalpana <anshikajain196872@gmail.com>
Anshikakalpana
force-pushed
the
fix-assert-diff-context
branch
from
f533b10 to
68fe8bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
new Assert({ diff: 'full' }), thediffoption was silently ignored inthrows,rejects,doesNotThrow, anddoesNotReject.expectsErrorandexpectsNoErrorwere not called with.call(this, ...), so the instancethiscontext was never passed through, causing thediffoption to always fall back to'simple'.Fix by passing
thiscontext using.call(this, ...)in all four methods.A regression test has been added to
test/parallel/test-assert-class.js.