dgram: add synchronous Socket.prototype.bindSync()#63838
Open
guybedford wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dgram
Provides sync non-blocking bind(2), without DNS lookup Signed-off-by: Guy Bedford <guybedford@gmail.com>
guybedford
force-pushed
the
dgram-bind-sync
branch
from
9263caa to
11b628c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebAssembly embeddings of libc UDP support relies on a synchronous
bind(2). Whilesocket.bindthat exposes this is asynchronous in Node.js, it is also completely fine to support a synchronous bind since it is a non-blocking operation in the OS when DNS resolution is excluded.This adds a very simple
socket.bindSyncto the dgram API, allowing a direct mode for posix compatibility layers on Node.js without requiring JSPI.