Skip to content

[v24.x] Revert "stream: noop pause/resume on destroyed streams"#63834

Open
sxa wants to merge 1 commit into
nodejs:v24.x-stagingfrom
sxa:revert_for_63487.1
Open

[v24.x] Revert "stream: noop pause/resume on destroyed streams"#63834
sxa wants to merge 1 commit into
nodejs:v24.x-stagingfrom
sxa:revert_for_63487.1

Conversation

@sxa

@sxa sxa commented Jun 10, 2026

Copy link
Copy Markdown
Member

This reverts commit 29b1966 from #62557

Should fix #63487 based on a git bisect run

This reverts commit 29b1966.

Signed-off-by: Stewart X Addison <sxa@ibm.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. labels Jun 10, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@sxa

sxa commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

Revert on top of v24.x-staging confirmed to have resolved the problem on my local system therefore I am taking this out of draft status.

@sxa sxa marked this pull request as ready for review June 10, 2026 12:56
@sxa

sxa commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

FYI @nodejs/tsc @nodejs/releasers

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm confirmed

@aduh95 aduh95 changed the title Revert "stream: noop pause/resume on destroyed streams" [v24.x] Revert "stream: noop pause/resume on destroyed streams" Jun 10, 2026
@MikeMcC399

MikeMcC399 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Successfully tested against cypress@15.15.0👍🏻


Cypress already produced a fix for this issue in cypress@15.16.0 so I'm testing against the previous unfixed version cypress@15.15.0.

The Cypress analysis of why it was failing on Windows (always) and Linux (when no unzip installed) is in cypress-io/cypress#33891 (comment). In both cases, extract-zip was being invoked and it failed on Node.js 24.16.0 and Node.js >=26.1.0 with the symptom that unzipping either hung or silently exited, depending on how the installation of the Cypress binary was invoked.


Verification

On Windows 11 25H2, in Git Bash with Node.js v24.16.1-pre, built from #63834, installed

cd $(mktemp -d)
npm install cypress@15.15.0 --ignore-scripts # fixed versions >=15.16.0
npx cypress install --force
npx cypress verify

Logs

$ cd $(mktemp -d)
npm install cypress@15.15.0 --ignore-scripts # fixed versions >=15.16.0
npx cypress install --force
npx cypress verify
npm warn cli npm v11.7.0 does not support Node.js v24.16.1-pre. This version of npm supports the following node versions: `^20.17.0 || >=22.9.0`. You can find the latest version at https://nodejs.org/.

added 175 packages in 6s

53 packages are looking for funding
  run `npm fund` for details
npm warn cli npm v11.7.0 does not support Node.js v24.16.1-pre. This version of npm supports the following node versions: `^20.17.0 || >=22.9.0`. You can find the latest version at https://nodejs.org/.

Cypress 15.15.0 is installed in C:\Users\mikem\AppData\Local\Cypress\Cache\15.15.0

Installing Cypress (version: 15.15.0)

√  Downloaded Cypress
√  Unzipped Cypress
√  Finished Installation C:\Users\mikem\AppData\Local\Cypress\Cache\15.15.0

You can now open Cypress by running one of the following, depending on your package manager:

- npx cypress open
- yarn cypress open
- pnpm cypress open

https://on.cypress.io/opening-the-app

npm warn cli npm v11.7.0 does not support Node.js v24.16.1-pre. This version of npm supports the following node versions: `^20.17.0 || >=22.9.0`. You can find the latest version at https://nodejs.org/.

√  Verified Cypress! C:\Users\mikem\AppData\Local\Cypress\Cache\15.15.0\Cypress

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants