Skip to content

http2: retain header memory in session accounting#63752

Open
mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:http2-harden-session-memory-headers
Open

http2: retain header memory in session accounting#63752
mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:http2-harden-session-memory-headers

Conversation

@mcollina
Copy link
Copy Markdown
Member

@mcollina mcollina commented Jun 5, 2026

Fix header memory accounting for stalled HTTP/2 streams and add regression coverage.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jun 5, 2026

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Jun 5, 2026
@mcollina
http2: retain header memory in session accounting
ef92a0d 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina mcollina force-pushed the http2-harden-session-memory-headers branch from 270bebd to ef92a0d Compare June 5, 2026 06:51
pimterry
pimterry approved these changes Jun 5, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@pimterry pimterry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, very nice 👍

@pimterry pimterry added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2026
@github-actions github-actions Bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jun 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2026

Failed to start CI
- Validating Jenkins credentials
✔  Jenkins credentials valid
- Starting PR CI job
✔  PR CI job successfully started

[DEBUG] [Error: GraphQL request Error: We couldn't respond to your request in time. Sorry about that. Please try resubmitting your request and contact us if the problem persists.] {

data: { variables: { prid: 63752, owner: 'nodejs', repo: 'node' } }

}

✘  Failed to start CI
https://github.com/nodejs/node/actions/runs/27008000368

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jun 5, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/73918/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pimterry pimterry pimterry approved these changes

+1 more reviewer

@metcoder95 metcoder95 metcoder95 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mcollina @nodejs-github-bot @pimterry @metcoder95