path: add escapeGlob and unescapeGlob

[Xstoudi]

path: add escapeGlob and unescapeGlob

Expose minimatch escaping and unescaping capabilities on path module.

Fixes: #61258

This is an implem proposal fix #61258 using minimatch that is already-vendored. Also feel free to -1 the change if you think it doesn't have its place there.

[nodejs-github-bot]

Review requested:

• @nodejs/path

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.15%. Comparing base (9041ad0) to head (e7ed644).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #61269      +/-   ##
==========================================
+ Coverage   90.12%   90.15%   +0.02%     
==========================================
  Files         743      743              
  Lines      242324   242368      +44     
  Branches    45629    45635       +6     
==========================================
+ Hits       218396   218501     +105     
+ Misses      15440    15359      -81     
- Partials     8488     8508      +20     

Files with missing lines	Coverage Δ
lib/internal/fs/glob.js	91.51% <100.00%> (+0.24%)	⬆️
lib/path.js	97.51% <100.00%> (+0.02%)	⬆️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Xstoudi]

Hey, no interest?

@nodejs/path

[targos]

@nodejs/path @nodejs/fs

[TheOneTheOnlyJJ]

I am wondering, why not just expose minimatch? It's already vendored, right?

[Xstoudi]

Vendoring is an implem detail, not a commitment and I'd prefer to not couple the Node's API to a third-party dependency.

Goal here is to provide stable, cross-platform glob semantic in Node rather than exposing raw minimatch behavior. windowsPathsNoEscape and magicalBraces are good illustrations of this.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/72403/

[Xstoudi]

Hey, is there something blocking this PR?

[valler]

The test cases don't include patterns containing parentheses ( and ). Is this intentional?

[Xstoudi]

No, I'll add some

[avivkeller]

@Xstoudi Please rebase

[github-actions]

Failed to start CI

- Validating Jenkins credentials
✔  Jenkins credentials valid
- Querying data for job/node-test-pull-request/72403/
[SyntaxError: Unexpected token '<', ..."    
  https://github.com/nodejs/node/actions/runs/30165172379

[github-actions]

Failed to start CI

- Validating Jenkins credentials
✔  Jenkins credentials valid
- Querying data for job/node-test-pull-request/72403/
[SyntaxError: Unexpected token '<', ..."    
  https://github.com/nodejs/node/actions/runs/30182123250

[trivikr]

This needs a rebase to resolve conflicts in test/parallel/test-path-glob.js

[TheOneTheOnlyJJ]

Should this be reconsidered around #65392? @avivkeller

[avivkeller]

If needed, since we won't have an escape function, this PR can be updated to vendor it's own escaping implementation, it's quite simple, it's just stringToEscape.replace(/[?*()[\]{}]/g, '[$&]')

[valler]

If needed, since we won't have an escape function, this PR can be updated to vendor it's own escaping implementation, it's quite simple, it's just stringToEscape.replace(/[?*()[\]{}]/g, '[$&]')

nice, that's more or less what #61258 gave as an example plus closing symbols.