Repository navigation
Conversation
Previously, both workflows ran with the repository's default token permissions, the CI jobs had no timeouts, and nothing tested the oldest Node.js version package.json allows. Now both workflows set permissions: contents: read, which is all any step needs, every CI job has a 5 minute timeout, and the test job runs on both latest and 26.9.0, the engines floor. Signed-off-by: Bryan English <bryan@bryanenglish.com>
trentm
approved these changes
Nov 3, 2026
bengl
marked this pull request as ready for review
November 3, 2026 19:42
legendecas
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Permissions. Both workflows now set
permissions: contents: read. No step calls the GitHub API.actions/checkoutneeds read access to the contents, and the build summary and the benchmark comparison write to$GITHUB_STEP_SUMMARY, which needs no token permission.Timeouts. The CI jobs had no timeouts. Recent runs put build, test, and prettier between 11 and 53 seconds, so each gets
timeout-minutes: 5. The benchmark job keeps its 20 minute timeout.Test matrix.
package.jsonrequires Node 26.9.0 or newer, but CI only testedlatest. The test job now runs onlatestand on 26.9.0. The floor is written out in the matrix rather than read frompackage.json, so changing the engines field means a deliberate change here too.fail-fastis off, so one leg failing doesn't cancel the other.Not checked locally. Both workflows parse as YAML, but they only really run on GitHub. This PR's own CI run is the real test.