fix: search exiting, markdown rendering - #955
Conversation
PR SummaryLow Risk Overview Sidebar labels share a new Two patch changesets cover these fixes for Reviewed by Cursor Bugbot for commit 6e7b974. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #955 +/- ##
==========================================
+ Coverage 86.50% 86.63% +0.12%
==========================================
Files 195 195
Lines 17964 17938 -26
Branches 1632 1632
==========================================
Hits 15540 15540
+ Misses 2418 2392 -26
Partials 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
| File | Main | PR | Change |
|---|---|---|---|
orama-db.json |
8.89 MB | 8.88 MB | -1.20 KB (-0.0%) |
Performance estimate (single CI run)
- Generation time: 1.5% faster (9.50 s → 9.36 s)
- Peak memory: 2.9% higher (1.74 GB → 1.79 GB)
web Generator
Output size: 220 files changed · net +5.41 KB
File size details
| File | Main | PR | Change |
|---|---|---|---|
assets/all-Ct60yyIi.js |
22.12 MB | — | -22.12 MB (-100.0%) |
assets/all-BZnZawCW.js |
— | 22.12 MB | +22.12 MB |
assets/fs-DfS23NDk.js |
1.55 MB | — | -1.55 MB (-100.0%) |
assets/fs-DUvz_loQ.js |
— | 1.55 MB | +1.55 MB |
assets/crypto-C9lzROGI.js |
1.37 MB | — | -1.37 MB (-100.0%) |
assets/crypto-CyXNwtxy.js |
— | 1.37 MB | +1.37 MB |
assets/buffer-4FKkuFq9.js |
1.14 MB | — | -1.14 MB (-100.0%) |
assets/buffer-CRexyefM.js |
— | 1.14 MB | +1.14 MB |
assets/test-ChYBlXf9.js |
1.01 MB | — | -1.01 MB (-100.0%) |
assets/test-CedwX-ZA.js |
— | 1.01 MB | +1.01 MB |
assets/stream-DDL1vcZa.js |
937.49 KB | — | -937.49 KB (-100.0%) |
assets/stream-COnfVr_G.js |
— | 937.49 KB | +937.49 KB |
assets/http2-Dhv6hgZN.js |
876.92 KB | — | -876.92 KB (-100.0%) |
assets/http2-G06Zc1cc.js |
— | 876.92 KB | +876.92 KB |
assets/util-Cy_5285j.js |
796.67 KB | — | -796.67 KB (-100.0%) |
assets/util-BolSjlFw.js |
— | 796.67 KB | +796.67 KB |
assets/http-BvPtpl24.js |
761.35 KB | — | -761.35 KB (-100.0%) |
assets/http-BAJQ5w38.js |
— | 761.35 KB | +761.35 KB |
assets/process-DPgSpyN8.js |
733.94 KB | — | -733.94 KB (-100.0%) |
assets/process-BBhdSQRs.js |
— | 733.94 KB | +733.94 KB |
assets/n-api-CZZU2aaT.js |
711.18 KB | — | -711.18 KB (-100.0%) |
assets/n-api-DVyrzFmz.js |
— | 711.18 KB | +711.18 KB |
assets/events-roCElnB7.js |
570.23 KB | — | -570.23 KB (-100.0%) |
assets/events-CqBkVOIR.js |
— | 570.23 KB | +570.23 KB |
assets/quic-0Pud6ZeJ.js |
563.48 KB | — | -563.48 KB (-100.0%) |
assets/quic-BWUha9Le.js |
— | 563.48 KB | +563.48 KB |
assets/stream_iter-Cm9I8OAy.js |
510.52 KB | — | -510.52 KB (-100.0%) |
assets/stream_iter-epKJ9S0J.js |
— | 510.52 KB | +510.52 KB |
assets/child_process-CePzN7gy.js |
490.99 KB | — | -490.99 KB (-100.0%) |
assets/child_process-Byqg-KaP.js |
— | 490.99 KB | +490.99 KB |
assets/assert-B6yslL6p.js |
473.91 KB | — | -473.91 KB (-100.0%) |
assets/assert-D41xPq55.js |
— | 473.91 KB | +473.91 KB |
assets/vm-Cc8jANgn.js |
466.32 KB | — | -466.32 KB (-100.0%) |
assets/vm-CtY_Yh70.js |
— | 466.32 KB | +466.32 KB |
assets/webcrypto-DxF7is9Q.js |
430.98 KB | — | -430.98 KB (-100.0%) |
assets/webcrypto-nKxyPh9b.js |
— | 430.98 KB | +430.98 KB |
assets/worker_threads-gorNEka4.js |
421.19 KB | — | -421.19 KB (-100.0%) |
assets/worker_threads-MAKkxgfS.js |
— | 421.19 KB | +421.19 KB |
assets/zlib-DJeNxZbf.js |
405.35 KB | — | -405.35 KB (-100.0%) |
assets/zlib-B98RV_rb.js |
— | 405.35 KB | +405.35 KB |
assets/perf_hooks-5oiXiWsD.js |
384.48 KB | — | -384.48 KB (-100.0%) |
assets/perf_hooks-DfTjyOjl.js |
— | 384.48 KB | +384.48 KB |
assets/net-D_PB70LX.js |
374.21 KB | — | -374.21 KB (-100.0%) |
assets/net-B1Ypdxr9.js |
— | 374.21 KB | +374.21 KB |
assets/errors-DBdNutsC.js |
373.22 KB | — | -373.22 KB (-100.0%) |
assets/errors-Byl5gChe.js |
— | 373.22 KB | +373.22 KB |
assets/v8-D_iIeX1_.js |
366.72 KB | — | -366.72 KB (-100.0%) |
assets/v8-Bvx5rZdR.js |
— | 366.72 KB | +366.72 KB |
assets/module-BkQKWJv5.js |
362.96 KB | — | -362.96 KB (-100.0%) |
assets/module-BALokZcK.js |
— | 362.96 KB | +362.96 KB |
assets/tls-Cy6RVmEY.js |
356.37 KB | — | -356.37 KB (-100.0%) |
assets/tls-UFJqY9mP.js |
— | 356.37 KB | +356.37 KB |
assets/url-keqhEX3f.js |
351.14 KB | — | -351.14 KB (-100.0%) |
assets/url-5PZJfZsc.js |
— | 351.14 KB | +351.14 KB |
assets/diagnostics_channel-CPysSURm.js |
337.49 KB | — | -337.49 KB (-100.0%) |
assets/diagnostics_channel-B4IL-Efr.js |
— | 337.49 KB | +337.49 KB |
assets/webstreams-Quy5DcuO.js |
328.11 KB | — | -328.11 KB (-100.0%) |
assets/webstreams-BHzFU3O5.js |
— | 328.11 KB | +328.11 KB |
assets/cli-CYTtemz7.js |
316.54 KB | — | -316.54 KB (-100.0%) |
assets/cli-DDC8h_Qn.js |
— | 316.54 KB | +316.54 KB |
assets/addons-CXfadmXN.js |
305.29 KB | — | -305.29 KB (-100.0%) |
assets/addons-lhuUrxzg.js |
— | 305.29 KB | +305.29 KB |
assets/sqlite-BlkHlf8s.js |
290.43 KB | — | -290.43 KB (-100.0%) |
assets/sqlite-CPSB3hWh.js |
— | 290.43 KB | +290.43 KB |
assets/dns-DDEgCIV-.js |
290.16 KB | — | -290.16 KB (-100.0%) |
assets/dns-DAKz-bbe.js |
— | 290.16 KB | +290.16 KB |
assets/deprecations-oj-Oo2dc.js |
279.12 KB | — | -279.12 KB (-100.0%) |
assets/deprecations-CJJlBAUK.js |
— | 279.12 KB | +279.12 KB |
assets/readline-DfKB5ufz.js |
232.99 KB | — | -232.99 KB (-100.0%) |
assets/readline-CNWKacnH.js |
— | 232.99 KB | +232.99 KB |
assets/async_context-35svDZ9e.js |
218.68 KB | — | -218.68 KB (-100.0%) |
assets/async_context-VqcMlI8m.js |
— | 218.68 KB | +218.68 KB |
assets/repl-B1nmbuGO.js |
207.09 KB | — | -207.09 KB (-100.0%) |
assets/repl-uaxJZglk.js |
— | 207.09 KB | +207.09 KB |
assets/cluster-C-AQ-i1a.js |
198.37 KB | — | -198.37 KB (-100.0%) |
assets/cluster-BLgTvfvc.js |
— | 198.37 KB | +198.37 KB |
assets/async_hooks-BcVQ1Itj.js |
195.28 KB | — | -195.28 KB (-100.0%) |
assets/async_hooks-BqTP1zJV.js |
— | 195.28 KB | +195.28 KB |
assets/dgram-BNOqB4Sp.js |
193.02 KB | — | -193.02 KB (-100.0%) |
assets/dgram-OE8DV8kJ.js |
— | 193.02 KB | +193.02 KB |
assets/ui-hKYzRRGR.js |
— | 189.53 KB | +189.53 KB |
assets/ui-CtCaVM3n.js |
189.39 KB | — | -189.39 KB (-100.0%) |
assets/report-D4_98n0W.js |
184.73 KB | — | -184.73 KB (-100.0%) |
assets/report-A64HOG32.js |
— | 184.73 KB | +184.73 KB |
assets/https-DarAcIR8.js |
161.04 KB | — | -161.04 KB (-100.0%) |
assets/https-Dhw5mi2X.js |
— | 161.04 KB | +161.04 KB |
assets/modules-Bpt2wBxq.js |
151.88 KB | — | -151.88 KB (-100.0%) |
assets/modules-BwKLeUVd.js |
— | 151.88 KB | +151.88 KB |
assets/packages-DaF0E9en.js |
147.40 KB | — | -147.40 KB (-100.0%) |
assets/packages-B6SKIF2r.js |
— | 147.40 KB | +147.40 KB |
assets/esm-E8hLopAp.js |
135.58 KB | — | -135.58 KB (-100.0%) |
assets/esm-CxyLL9GG.js |
— | 135.58 KB | +135.58 KB |
assets/globals-BDFqOgIW.js |
130.04 KB | — | -130.04 KB (-100.0%) |
assets/globals-gt_GTiQw.js |
— | 130.04 KB | +130.04 KB |
assets/inspector-C3plsGjy.js |
124.68 KB | — | -124.68 KB (-100.0%) |
assets/inspector-CwDIq-d_.js |
— | 124.68 KB | +124.68 KB |
assets/os-Dl7HELks.js |
110.85 KB | — | -110.85 KB (-100.0%) |
assets/os-6ynSW3Mg.js |
— | 110.85 KB | +110.85 KB |
assets/ffi-DQHLJJwL.js |
109.12 KB | — | -109.12 KB (-100.0%) |
assets/ffi-DatjoGig.js |
— | 109.12 KB | +109.12 KB |
assets/console-CfdKuCbz.js |
106.25 KB | — | -106.25 KB (-100.0%) |
assets/console-DUODhVry.js |
— | 106.25 KB | +106.25 KB |
assets/timers-DY3HbxfS.js |
101.31 KB | — | -101.31 KB (-100.0%) |
assets/timers-kruhnUzt.js |
— | 101.31 KB | +101.31 KB |
assets/dtls-Ddnfg7dr.js |
99.62 KB | — | -99.62 KB (-100.0%) |
assets/dtls-LxRvU0Hv.js |
— | 99.62 KB | +99.62 KB |
assets/path-zDPqyND8.js |
99.24 KB | — | -99.24 KB (-100.0%) |
assets/path-BNdRKn9G.js |
— | 99.24 KB | +99.24 KB |
assets/debugger-CH-aY0h9.js |
94.31 KB | — | -94.31 KB (-100.0%) |
assets/debugger-Cx2ksR92.js |
— | 94.31 KB | +94.31 KB |
assets/domain-Dvn3iTpx.js |
87.42 KB | — | -87.42 KB (-100.0%) |
assets/domain-DGDvWDSb.js |
— | 87.42 KB | +87.42 KB |
assets/single-executable-applications-kjBxOOnV.js |
82.54 KB | — | -82.54 KB (-100.0%) |
assets/single-executable-applications-CjYvadlV.js |
— | 82.54 KB | +82.54 KB |
assets/tracing-DLs9CRX2.js |
73.90 KB | — | -73.90 KB (-100.0%) |
assets/tracing-KUyfQMLj.js |
— | 73.90 KB | +73.90 KB |
assets/tty-D9uVfM02.js |
48.25 KB | — | -48.25 KB (-100.0%) |
assets/tty-CH4HPPAo.js |
— | 48.25 KB | +48.25 KB |
assets/vfs-RJSoxvBH.js |
46.04 KB | — | -46.04 KB (-100.0%) |
assets/vfs-eJ0QY0Wq.js |
— | 46.04 KB | +46.04 KB |
assets/wasi-uGoLb5oK.js |
40.83 KB | — | -40.83 KB (-100.0%) |
assets/wasi-BaJQECjm.js |
— | 40.83 KB | +40.83 KB |
assets/permissions-taYhW9AG.js |
34.82 KB | — | -34.82 KB (-100.0%) |
assets/permissions-C5MPz7Ra.js |
— | 34.82 KB | +34.82 KB |
assets/embedding-oU82-G0W.js |
33.42 KB | — | -33.42 KB (-100.0%) |
assets/embedding-CceYSRjX.js |
— | 33.42 KB | +33.42 KB |
assets/intl-DEwtIU0W.js |
32.44 KB | — | -32.44 KB (-100.0%) |
assets/intl-Dq70yO90.js |
— | 32.44 KB | +32.44 KB |
assets/querystring-Cy4xsTPk.js |
29.92 KB | — | -29.92 KB (-100.0%) |
assets/querystring-B6cwD55k.js |
— | 29.92 KB | +29.92 KB |
assets/string_decoder-Dp_Y92gG.js |
28.32 KB | — | -28.32 KB (-100.0%) |
assets/string_decoder-K6tV7h1f.js |
— | 28.32 KB | +28.32 KB |
assets/punycode-B0RI1WFH.js |
24.66 KB | — | -24.66 KB (-100.0%) |
assets/punycode-JPYorDmv.js |
— | 24.66 KB | +24.66 KB |
assets/typescript-cyJZ9ovA.js |
21.60 KB | — | -21.60 KB (-100.0%) |
assets/typescript-uGj5ZwkH.js |
— | 21.60 KB | +21.60 KB |
assets/index-BKEGgRXL.js |
13.83 KB | — | -13.83 KB (-100.0%) |
assets/index-DLpOGZaE.js |
— | 13.83 KB | +13.83 KB |
assets/environment_variables-x0rRCRPK.js |
11.73 KB | — | -11.73 KB (-100.0%) |
assets/environment_variables-BQaBkpEl.js |
— | 11.73 KB | +11.73 KB |
assets/synopsis-dTkOnk-T.js |
11.42 KB | — | -11.42 KB (-100.0%) |
assets/synopsis-BcA9c1cM.js |
— | 11.42 KB | +11.42 KB |
assets/documentation-Dfeipv02.js |
4.84 KB | — | -4.84 KB (-100.0%) |
assets/documentation-CcTDAzEP.js |
— | 4.84 KB | +4.84 KB |
assets/CodeBox-OhcnL93l.js |
3.02 KB | — | -3.02 KB (-100.0%) |
assets/CodeBox-x5fkvvmN.js |
— | 3.02 KB | +3.02 KB |
assets/404-DVLui6_T.js |
627.00 B | — | -627.00 B (-100.0%) |
assets/404-CO02UGOX.js |
— | 627.00 B | +627.00 B |
module.html |
351.15 KB | 351.30 KB | +148.00 B (+0.0%) |
404.html |
28.70 KB | 28.78 KB | +74.00 B (+0.3%) |
addons.html |
273.62 KB | 273.69 KB | +74.00 B (+0.0%) |
all.html |
21.35 MB | 21.35 MB | +74.00 B (+0.0%) |
assert.html |
347.32 KB | 347.39 KB | +74.00 B (+0.0%) |
async_context.html |
190.67 KB | 190.75 KB | +74.00 B (+0.0%) |
async_hooks.html |
161.85 KB | 161.92 KB | +74.00 B (+0.0%) |
buffer.html |
955.67 KB | 955.75 KB | +74.00 B (+0.0%) |
child_process.html |
406.60 KB | 406.68 KB | +74.00 B (+0.0%) |
cli.html |
516.77 KB | 516.84 KB | +74.00 B (+0.0%) |
cluster.html |
203.09 KB | 203.16 KB | +74.00 B (+0.0%) |
console.html |
148.71 KB | 148.78 KB | +74.00 B (+0.0%) |
crypto.html |
1.21 MB | 1.21 MB | +74.00 B (+0.0%) |
debugger.html |
99.59 KB | 99.66 KB | +74.00 B (+0.1%) |
deprecations.html |
496.84 KB | 496.92 KB | +74.00 B (+0.0%) |
dgram.html |
218.11 KB | 218.18 KB | +74.00 B (+0.0%) |
diagnostics_channel.html |
329.06 KB | 329.13 KB | +74.00 B (+0.0%) |
dns.html |
318.66 KB | 318.73 KB | +74.00 B (+0.0%) |
documentation.html |
36.70 KB | 36.77 KB | +74.00 B (+0.2%) |
domain.html |
105.33 KB | 105.40 KB | +74.00 B (+0.1%) |
dtls.html |
160.70 KB | 160.78 KB | +74.00 B (+0.0%) |
embedding.html |
58.21 KB | 58.29 KB | +74.00 B (+0.1%) |
environment_variables.html |
42.83 KB | 42.90 KB | +74.00 B (+0.2%) |
errors.html |
493.18 KB | 493.25 KB | +74.00 B (+0.0%) |
esm.html |
157.86 KB | 157.94 KB | +74.00 B (+0.0%) |
events.html |
478.82 KB | 478.89 KB | +74.00 B (+0.0%) |
ffi.html |
143.33 KB | 143.41 KB | +74.00 B (+0.1%) |
fs.html |
1.68 MB | 1.68 MB | +74.00 B (+0.0%) |
globals.html |
235.48 KB | 235.55 KB | +74.00 B (+0.0%) |
http.html |
815.29 KB | 815.36 KB | +74.00 B (+0.0%) |
http2.html |
838.15 KB | 838.22 KB | +74.00 B (+0.0%) |
https.html |
153.70 KB | 153.77 KB | +74.00 B (+0.0%) |
index.html |
39.28 KB | 39.35 KB | +74.00 B (+0.2%) |
inspector.html |
178.19 KB | 178.26 KB | +74.00 B (+0.0%) |
intl.html |
56.93 KB | 57.00 KB | +74.00 B (+0.1%) |
modules.html |
184.57 KB | 184.64 KB | +74.00 B (+0.0%) |
n-api.html |
810.80 KB | 810.87 KB | +74.00 B (+0.0%) |
net.html |
484.36 KB | 484.43 KB | +74.00 B (+0.0%) |
os.html |
150.64 KB | 150.71 KB | +74.00 B (+0.0%) |
packages.html |
177.99 KB | 178.06 KB | +74.00 B (+0.0%) |
path.html |
143.83 KB | 143.90 KB | +74.00 B (+0.1%) |
perf_hooks.html |
407.63 KB | 407.71 KB | +74.00 B (+0.0%) |
permissions.html |
61.64 KB | 61.71 KB | +74.00 B (+0.1%) |
process.html |
719.34 KB | 719.41 KB | +74.00 B (+0.0%) |
punycode.html |
62.97 KB | 63.04 KB | +74.00 B (+0.1%) |
querystring.html |
65.43 KB | 65.50 KB | +74.00 B (+0.1%) |
quic.html |
834.15 KB | 834.22 KB | +74.00 B (+0.0%) |
readline.html |
263.32 KB | 263.39 KB | +74.00 B (+0.0%) |
repl.html |
183.05 KB | 183.12 KB | +74.00 B (+0.0%) |
report.html |
174.71 KB | 174.78 KB | +74.00 B (+0.0%) |
single-executable-applications.html |
107.70 KB | 107.77 KB | +74.00 B (+0.1%) |
sqlite.html |
315.32 KB | 315.39 KB | +74.00 B (+0.0%) |
stream.html |
926.62 KB | 926.69 KB | +74.00 B (+0.0%) |
stream_iter.html |
409.45 KB | 409.52 KB | +74.00 B (+0.0%) |
string_decoder.html |
55.42 KB | 55.49 KB | +74.00 B (+0.1%) |
synopsis.html |
41.46 KB | 41.53 KB | +74.00 B (+0.2%) |
test.html |
898.81 KB | 898.88 KB | +74.00 B (+0.0%) |
timers.html |
138.92 KB | 138.99 KB | +74.00 B (+0.1%) |
tls.html |
414.46 KB | 414.53 KB | +74.00 B (+0.0%) |
tracing.html |
84.04 KB | 84.12 KB | +74.00 B (+0.1%) |
tty.html |
98.09 KB | 98.16 KB | +74.00 B (+0.1%) |
typescript.html |
52.26 KB | 52.33 KB | +74.00 B (+0.1%) |
url.html |
363.30 KB | 363.38 KB | +74.00 B (+0.0%) |
util.html |
735.02 KB | 735.09 KB | +74.00 B (+0.0%) |
v8.html |
358.26 KB | 358.33 KB | +74.00 B (+0.0%) |
vfs.html |
83.73 KB | 83.80 KB | +74.00 B (+0.1%) |
vm.html |
396.20 KB | 396.27 KB | +74.00 B (+0.0%) |
wasi.html |
70.49 KB | 70.56 KB | +74.00 B (+0.1%) |
webcrypto.html |
566.72 KB | 566.79 KB | +74.00 B (+0.0%) |
webstreams.html |
397.80 KB | 397.88 KB | +74.00 B (+0.0%) |
worker_threads.html |
393.55 KB | 393.63 KB | +74.00 B (+0.0%) |
zlib.html |
380.13 KB | 380.20 KB | +74.00 B (+0.0%) |
Performance estimate (single CI run)
- Generation time: 6.2% faster (76.79 s → 72.02 s)
- Peak memory: 0.8% lower (5.20 GB → 5.16 GB)
|
It seems the problem is only partially solved. When I search for "join" on the path page and then navigate to it, the overlay disappears, but the page content remains at the top and does not navigate to the specified method location. |
|
Bump @nodejs/web-infra |
This appears to be working for me now using the same attempted work - can you re-verify? |
It's working as of 6c3b92d, which "forces" the browser to scroll, as some won't do it automatically for whatever reason |
6c3b92d to
6e7b974
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6e7b974. Configure here.
| document | ||
| .getElementById(decodeURIComponent(target.hash.slice(1))) | ||
| ?.scrollIntoView() | ||
| ); |
There was a problem hiding this comment.
Same-page search omits URL hash
Medium Severity
followSearchHit always calls preventDefault, then on same-pathname hits only scrollIntoViews the target. That closes the modal and moves the viewport, but never updates location.hash or history, so the URL no longer reflects the section the user opened via search (unlike a normal in-page anchor click).
Reviewed by Cursor Bugbot for commit 6e7b974. Configure here.


I know this change isn't idiomatic (hence why I wrote two changesets), I just have multiple open PRs in this repo, and I felt like it would be excessive to open two more for these simple fixes.
Fixes #927 by moving the
renderLabelutility out ofwwwand into the package itself (which turns backticks into code blocks)Fixes #943 by adding an
onClickhandler to the search button, whichESC-es the Search (if the user isn't redirected away, that is)