Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1116 +/- ##
==========================================
+ Coverage 91.38% 91.42% +0.03%
==========================================
Files 249 249
Lines 23253 23347 +94
Branches 2244 2257 +13
==========================================
+ Hits 21250 21344 +94
Misses 1994 1994
Partials 9 9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
| File | Main | PR | Change |
|---|---|---|---|
orama-db.json |
9.54 MB | 9.54 MB | +152.00 B (+0.0%) |
Performance estimate (single CI run)
- Generation time: 23.3% faster (6.45 s → 4.95 s)
- Peak memory: 7.3% higher (1.76 GB → 1.89 GB)
web Generator
Output size: 14 files changed · net +3.21 KB
File size details
| File | Main | PR | Change |
|---|---|---|---|
all.html |
32.97 MB | 32.97 MB | +1.60 KB (+0.0%) |
webstreams.html |
535.38 KB | 535.70 KB | +326.00 B (+0.1%) |
stream.html |
1.22 MB | 1.22 MB | +292.00 B (+0.0%) |
crypto.html |
1.96 MB | 1.96 MB | +268.00 B (+0.0%) |
globals.html |
281.61 KB | 281.78 KB | +174.00 B (+0.1%) |
sqlite.html |
520.05 KB | 520.19 KB | +150.00 B (+0.0%) |
events.html |
834.21 KB | 834.35 KB | +145.00 B (+0.0%) |
diagnostics_channel.html |
529.81 KB | 529.93 KB | +126.00 B (+0.0%) |
stream_iter.html |
734.29 KB | 734.41 KB | +124.00 B (+0.0%) |
webcrypto.html |
640.93 KB | 640.94 KB | +14.00 B (+0.0%) |
dtls.html |
300.38 KB | 300.38 KB | +8.00 B (+0.0%) |
net.html |
633.42 KB | 633.43 KB | +8.00 B (+0.0%) |
quic.html |
924.12 KB | 924.13 KB | +3.00 B (+0.0%) |
tls.html |
523.79 KB | 523.80 KB | +3.00 B (+0.0%) |
Performance estimate (single CI run)
- Generation time: 0.2% faster (66.31 s → 66.16 s)
- Peak memory: 13.0% lower (3.72 GB → 3.24 GB)
| let end = -1; | ||
| let index = code.indexOf(name); | ||
|
|
||
| while (index !== -1) { |
There was a problem hiding this comment.
nit: Is while the best idiomatic way to do this? I'd rather do something that uses Iterable APIs...
Description
getFullNamelocated the entry name withindexOf, which matched the first occurrence of the name anywhere in the heading — including inside the receiver.diagnostics_channel.channelwas thus truncated todiagnostics_channel, and the same bug affectedsign.sign,emitter.emit,readable.read, and 8 other headings.Validation
Related Issues
Check List
node --run testand all tests passed.node --run format:check&node --run lint.