feat(legacy-json): make source path configurable - #1111
Open
moshams272 wants to merge 1 commit into
Open
moshams272 wants to merge 1 commit into
moshams272 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1111 +/- ##
==========================================
- Coverage 91.38% 91.37% -0.01%
==========================================
Files 249 249
Lines 23253 23261 +8
Branches 2244 2244
==========================================
+ Hits 21250 21255 +5
- Misses 1994 1997 +3
Partials 9 9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
| File | Main | PR | Change |
|---|---|---|---|
orama-db.json |
9.50 MB | 9.50 MB | +126.00 B (+0.0%) |
Performance estimate (single CI run)
- Generation time: 21.4% slower (4.96 s → 6.02 s)
- Peak memory: 3.6% lower (1.77 GB → 1.70 GB)
web Generator
Performance estimate (single CI run)
- Generation time: 39.8% slower (45.46 s → 63.55 s)
- Peak memory: 6.2% higher (3.47 GB → 3.68 GB)
avivkeller
reviewed
Sep 25, 2026
moshams272
force-pushed
the
feat/configurable-source-prefix
branch
from
September 25, 2026 18:07
bb86aaa to
e39e886
Compare
AugustinMauroy
approved these changes
Sep 25, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the source path for legacy JSON generators configurable instead of hardcoded.
Validation
Tested locally.
Related Issues
None.
Check List
node --run testand all tests passed.node --run format:check&node --run lint.