fix(core): respect log level in worker threads by zeexzeex · Pull Request #1058 · nodejs/doc-kit

zeexzeex · 2026-08-27T07:07:47Z

What

--log-level had no effect on warnings coming from worker threads.

npx @doc-kit/cli generate -t web -o out -i <node>/doc/api/ --log-level fatal

printed 81 WARN lines instead of none.

Why

The level is applied on the main thread only. Worker threads load their own module graph, so the default logger export creates a separate instance there that keeps the default info level. The warnings in the report come from resolveTypes.mjs, which runs inside the workers.

The same input makes it clear:

Input	Workers used	default level	`--log-level fatal`
single file	no	6 WARN	0 WARN
directory (`doc/api/`)	yes	81 WARN	81 WARN

Both inputs produce warnings, but only the single file respects the requested level. parallel.mjs skips the pool when threads <= 1 || items.length <= 2, so running the directory with --threads 1 silences the warnings as well.

How

The level is passed through Piscina workerData and applied at the worker entry point. This adds a small getLogLevel() accessor, as there was no way to read the configured level back.

I also considered putting the level into configuration, which already reaches the workers, but createTask deliberately narrows what it sends:

// Only pass the needed configuration to this generator
configuration: {
  [generatorName]: configuration[generatorName],
},

Sending the level that way would repeat it for every chunk, while workerData is sent once per worker.

Verification

Case	Before	After
`--log-level fatal`	81 WARN	0 WARN
default level	81 WARN	81 WARN

The default level is unchanged, so nothing is silenced that should not be. Full suite passes (560 tests), lint and format checks are clean.

Fixes: #1032

The log level set by `--log-level` was only applied on the main thread. Worker threads load their own module graph, so the default logger export creates a separate instance there that keeps the default `info` level. Warnings emitted from inside workers were therefore printed regardless of the requested level. Pass the level through Piscina `workerData` and apply it at the worker entry point. This adds a `getLogLevel()` accessor, as there was no way to read the configured level back. Fixes: nodejs#1032 Signed-off-by: Avocado <ujubongbong@gmail.com>

vercel · 2026-08-27T07:07:53Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
api-docs-tooling	Ready	Preview	Aug 27, 2026 7:49am

AugustinMauroy · 2026-08-27T07:21:55Z

could you add some test

codecov · 2026-08-27T07:22:06Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.77%. Comparing base (18b9423) to head (59cba19).
⚠️ Report is 30 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1058      +/-   ##
==========================================
+ Coverage   89.67%   90.77%   +1.10%     
==========================================
  Files         205      221      +16     
  Lines       19208    21267    +2059     
  Branches     1795     2003     +208     
==========================================
+ Hits        17224    19305    +2081     
+ Misses       1976     1956      -20     
+ Partials        8        6       -2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-08-27T07:23:44Z