Skip to content

test: use npm_config_allow_git all to install from git source (npm 12) - #1133

Open
MikeMcC399 wants to merge 1 commit into
nodejs:mainfrom
MikeMcC399:fix/install-from-git-test
Open

test: use npm_config_allow_git all to install from git source (npm 12)#1133
MikeMcC399 wants to merge 1 commit into
nodejs:mainfrom
MikeMcC399:fix/install-from-git-test

Conversation

@MikeMcC399

Copy link
Copy Markdown
Contributor

Situation

npx tap test/test-citgm.js includes a test

"citgm: omg-i-pass from git url" which installs directly from the URI

git+https://github.com/MylesBorins/omg-i-pass

This fails under npm 12 with EALLOWGIT because npm@12.0.0 disallows installing git tarball dependencies.

See https://docs.npmjs.com/cli/v12/using-npm/config#allow-git

Change

Add the environment variable npm_config_allow_git: 'all' to the test "citgm: omg-i-pass from git url" in test/test-citgm.js.

Verification

Test in CI actions/workflows/nodejs.yml for compatibility with npm 10 & 11.

Test locally using Node.js 26.7.0 / npm 12.0.2:

npx tap test/test-citgm.js
Checklist
  • npm test passes
  • contribution guidelines followed
    here

changed for npm 12 compatibility
which otherwise throws an error EALLOWGIT when attempting
to install from a git source

Signed-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
@codecov-commenter

codecov-commenter commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.11%. Comparing base (eef880d) to head (b74aff8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1133      +/-   ##
==========================================
- Coverage   96.20%   95.11%   -1.09%     
==========================================
  Files          29       29              
  Lines        2213     2213              
==========================================
- Hits         2129     2105      -24     
- Misses         84      108      +24     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MikeMcC399
MikeMcC399 marked this pull request as ready for review August 22, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants