Skip to content

ci: pin setup-vp to cache reserve-race warning fix#793

Closed
fengmk2 wants to merge 2 commits into
masterfrom
chore/setup-vp-cache-warning-fix
Closed

ci: pin setup-vp to cache reserve-race warning fix#793
fengmk2 wants to merge 2 commits into
masterfrom
chore/setup-vp-cache-warning-fix

Conversation

@fengmk2
Copy link
Copy Markdown
Member

@fengmk2 fengmk2 commented May 29, 2026

What

Pins voidzero-dev/setup-vp in nodejs.yml (both the check and matrix test jobs) to the fix commit b250484 from voidzero-dev/setup-vp#75.

Why

Our CI was producing harmless-but-noisy warning annotations from setup-vp's cache step, e.g. in run #26621172939:

! Cache save failed or was skipped.
! Failed to save: Unable to reserve cache with key vite-plus-Linux-x64-pnpm-…, another job may be creating this cache.

Root cause: setup-vp's cache key is vite-plus-{OS}-{arch}-{lockfile}-{hash} and intentionally excludes the Node version (the package-manager store is Node-version-independent). Our matrix runs 3 Node versions per OS, so those jobs share one key and race to save it in the post step. GitHub lets only one job reserve a key; the losers get a benign -1, which setup-vp was surfacing as a warning annotation. Caching itself always worked.

setup-vp#75 demotes that benign path from warning to info. This PR's CI run should come back without the Cache save failed or was skipped. annotations.

Note

This is a temporary SHA pin for verification. Once setup-vp#75 is merged and the v1 tag is re-cut, revert these two lines back to voidzero-dev/setup-vp@v1 (which will then carry the fix automatically). The release.yml and pkg.pr.new.yml workflows are left on @v1 (single-job, no matrix → no warnings).

Summary by CodeRabbit

  • Chores
    • Pinned a CI action to a specific commit SHA in the check and test workflow jobs (including matrix runs) to stabilize CI behavior; change is marked temporary and will be reverted after release.

Review Change Stack

The matrix CI jobs that share a setup-vp cache key (same OS/arch/lockfile
across Node versions) race to save it; the losers emitted noisy
"Cache save failed or was skipped." warning annotations even though
caching worked. Pin setup-vp to the fix commit to verify the warnings
are gone in this PR's CI run.

Temporary SHA pin — revert to @v1 once voidzero-dev/setup-vp#75 is
merged and the v1 tag is re-cut.
Copilot AI review requested due to automatic review settings May 29, 2026 07:55
@gemini-code-assist
Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e9d1db14-27dc-4d35-bb5d-94e40d35ffd2

📥 Commits

Reviewing files that changed from the base of the PR and between 04a54e3 and 88ee44b.

📒 Files selected for processing (1)
  • .github/workflows/nodejs.yml

📝 Walkthrough

Walkthrough

The GitHub Actions workflow pins voidzero-dev/setup-vp to commit 6cb180a2f884264930ebcd4169f924720120c4b4 in both the check and test jobs, replacing @v1; inline comments note this is a temporary mitigation for cache reserve-race warnings.

Changes

Workflow Action Pin Update

Layer / File(s) Summary
Pin setup-vp action across jobs
.github/workflows/nodejs.yml
voidzero-dev/setup-vp is changed from @v1 to commit 6cb180a2f884264930ebcd4169f924720120c4b4 in the check job and the test job matrix setup step; an inline comment documents the temporary nature.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A tiny hash hops into the run,
Silencing caches till the release is done,
Two steps now steady, no more quiet fright,
We’ll leap back to v1 when the timing’s right.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'ci: pin setup-vp to cache reserve-race warning fix' clearly and specifically summarizes the main change: pinning a GitHub Action to address a cache warning issue in CI workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/setup-vp-cache-warning-fix

Warning

Review ran into problems

🔥 Problems

Stopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a @coderabbit review after the pipeline has finished.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 29, 2026

Open in StackBlitz

npm i https://pkg.pr.new/node-modules/urllib@793

commit: 88ee44b

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.65%. Comparing base (0bbc400) to head (88ee44b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #793   +/-   ##
=======================================
  Coverage   94.65%   94.65%           
=======================================
  Files          10       10           
  Lines         730      730           
  Branches      228      228           
=======================================
  Hits          691      691           
  Misses         36       36           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the voidzero-dev/setup-vp GitHub Action in the CI workflow to a specific commit that demotes the benign “cache reserve race” path from a warning annotation to an info message, reducing CI noise in matrix runs.

Changes:

  • Pin voidzero-dev/setup-vp to commit b250484f0d7da679524e2f30c1330935444328f9 in the check job.
  • Pin voidzero-dev/setup-vp to the same commit in the matrix test job.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

setup-vp 6cb180a additionally fixes the @actions/cache "Failed to save:
Unable to reserve cache…" warning, which was caused by class-name mangling
in the action bundle (error.name === ReserveCacheError.name never matched).

Temporary SHA pin — revert to @v1 once voidzero-dev/setup-vp#75 is merged
and the v1 tag is re-cut.
@fengmk2 fengmk2 closed this May 29, 2026
@fengmk2 fengmk2 deleted the chore/setup-vp-cache-warning-fix branch May 29, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants