ci: pin setup-vp to cache reserve-race warning fix#793
Conversation
The matrix CI jobs that share a setup-vp cache key (same OS/arch/lockfile across Node versions) race to save it; the losers emitted noisy "Cache save failed or was skipped." warning annotations even though caching worked. Pin setup-vp to the fix commit to verify the warnings are gone in this PR's CI run. Temporary SHA pin — revert to @v1 once voidzero-dev/setup-vp#75 is merged and the v1 tag is re-cut.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe GitHub Actions workflow pins ChangesWorkflow Action Pin Update
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsStopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #793 +/- ##
=======================================
Coverage 94.65% 94.65%
=======================================
Files 10 10
Lines 730 730
Branches 228 228
=======================================
Hits 691 691
Misses 36 36
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Pins the voidzero-dev/setup-vp GitHub Action in the CI workflow to a specific commit that demotes the benign “cache reserve race” path from a warning annotation to an info message, reducing CI noise in matrix runs.
Changes:
- Pin
voidzero-dev/setup-vpto commitb250484f0d7da679524e2f30c1330935444328f9in thecheckjob. - Pin
voidzero-dev/setup-vpto the same commit in the matrixtestjob.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
setup-vp 6cb180a additionally fixes the @actions/cache "Failed to save: Unable to reserve cache…" warning, which was caused by class-name mangling in the action bundle (error.name === ReserveCacheError.name never matched). Temporary SHA pin — revert to @v1 once voidzero-dev/setup-vp#75 is merged and the v1 tag is re-cut.
What
Pins
voidzero-dev/setup-vpinnodejs.yml(both thecheckand matrixtestjobs) to the fix commitb250484from voidzero-dev/setup-vp#75.Why
Our CI was producing harmless-but-noisy warning annotations from setup-vp's cache step, e.g. in run #26621172939:
Root cause: setup-vp's cache key is
vite-plus-{OS}-{arch}-{lockfile}-{hash}and intentionally excludes the Node version (the package-manager store is Node-version-independent). Our matrix runs 3 Node versions per OS, so those jobs share one key and race to save it in the post step. GitHub lets only one job reserve a key; the losers get a benign-1, which setup-vp was surfacing as a warning annotation. Caching itself always worked.setup-vp#75 demotes that benign path from
warningtoinfo. This PR's CI run should come back without theCache save failed or was skipped.annotations.Note
This is a temporary SHA pin for verification. Once setup-vp#75 is merged and the
v1tag is re-cut, revert these two lines back tovoidzero-dev/setup-vp@v1(which will then carry the fix automatically). Therelease.ymlandpkg.pr.new.ymlworkflows are left on@v1(single-job, no matrix → no warnings).Summary by CodeRabbit