Skip to content

feat: upgrade to Typescript 7 - #238

Open
nikilok wants to merge 1 commit into
mainfrom
chore/typescript-7
Open

feat: upgrade to Typescript 7#238
nikilok wants to merge 1 commit into
mainfrom
chore/typescript-7

Conversation

@nikilok

@nikilok nikilok commented Jul 9, 2026

Copy link
Copy Markdown
Owner
  • upgrade to TS 7
  • fix a few type errors
  • add typecheck to the CI so we dont introduce type errors

Summary by CodeRabbit

  • New Features

    • Added a repository-wide TypeScript typecheck command and pipeline step to CI.
    • Added app/package-level typecheck scripts across the codebase for easier local checks.
  • Bug Fixes

    • Updated database client typing so SQL query types are sourced from the shared database package.
    • Refreshed the TypeScript version used by the project.
  • Chores

    • Renamed the CI lint step to better reflect the checks it runs.

- upgrade to TS 7
- fix a few type errors
- add typecheck to the CI so we dont introduce type errors
@vercel

vercel Bot commented Jul 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
learn-tanstack-start Error Error Jul 20, 2026 12:10pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 639fdaf5-1646-4eba-851c-5d41e29ea0d4

📥 Commits

Reviewing files that changed from the base of the PR and between 47d67f2 and acf2bf9.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (10)
  • .github/workflows/ci.yaml
  • apps/ch-stream/package.json
  • apps/desktop/package.json
  • apps/firewall/package.json
  • apps/web/package.json
  • apps/web/src/lib/phase5/sql.ts
  • package.json
  • packages/db/package.json
  • packages/db/src/client.ts
  • turbo.json

📝 Walkthrough

Walkthrough

This PR introduces a typecheck script (running tsc --noEmit) across root and workspace packages, adds a corresponding typecheck task to turbo.json, adds a CI step to run it, upgrades TypeScript to ^7.0.2, re-exports NeonQueryFunction from packages/db/src/client.ts, and updates its import source in apps/web/src/lib/phase5/sql.ts.

Changes

Typecheck Task Rollout

Layer / File(s) Summary
Root orchestration and TypeScript upgrade
turbo.json, package.json
Adds a typecheck Turbo task and a root typecheck script running turbo run typecheck; upgrades typescript devDependency from ^6.0.3 to ^7.0.2.
Per-package typecheck scripts
apps/ch-stream/package.json, apps/desktop/package.json, apps/firewall/package.json, apps/web/package.json, packages/db/package.json
Adds typecheck (tsc --noEmit) scripts to each package, alongside existing lint:fix entries.
CI typecheck step
.github/workflows/ci.yaml
Renames the lint/format job step and adds a new step running bun run typecheck.
Neon client type export and import update
packages/db/src/client.ts, apps/web/src/lib/phase5/sql.ts
Re-exports NeonQueryFunction type from packages/db/src/client.ts and updates the import source used for the Sql type alias in apps/web/src/lib/phase5/sql.ts.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly reflects the main change: upgrading the project to TypeScript 7.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/typescript-7

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant