Skip to content

Fix nirfsa and nirfsg deembedding system tests to match with new driver behaviour #2233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ni-jfitzger merged 6 commits into from
Oct 22, 2026
Merged

Fix nirfsa and nirfsg deembedding system tests to match with new driver behaviour #2233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
447d03a
test modified
mohit-emerson Oct 22, 2026
6c462ef
changelog updated
mohit-emerson Oct 22, 2026
949b2b0
PR comments
mohit-emerson Oct 22, 2026
db033c3
test_reset_with_options modified
mohit-emerson Oct 22, 2026
f1a37cc
PR comments addressed
mohit-emerson Oct 22, 2026
86c6df7
try catch block removed
mohit-emerson Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions src/nirfsa/system_tests/test_system_nirfsa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,12 +179,7 @@ def test_reset_with_options(self, rfsa_device_session):
# Reset with no omitted steps deletes the de-embedding tables.
rfsa_device_session.reset_with_options(steps_to_omit_none)
rfsa_device_session.ports[''].deembedding_selected_table = 'myTable1'
try:
rfsa_device_session.commit()
assert False
except nirfsa.Error as e:
assert e.code == -1074097772
assert 'de-embedding table cannot be found' in e.description
rfsa_device_session.commit()

@pytest.mark.skipif(use_simulated_session is False, reason="Takes long time on real device")
def test_self_cal_range(self, rfsa_device_session):
Expand Down Expand Up @@ -571,12 +566,7 @@ def test_create_deembedding_sparameter_table_s2p_file(self, rfsa_device_session)
with rfsa_device_session.initiate():
rfsa_device_session.check_acquisition_status()
rfsa_device_session.delete_all_deembedding_tables()
try:
rfsa_device_session.commit()
assert False
except nirfsa.Error as e:
assert e.code == -1074097772
assert 'de-embedding table cannot be found' in e.description
rfsa_device_session.commit()
rfsa_device_session.ports[''].deembedding_selected_table = ''
with rfsa_device_session.initiate():
rfsa_device_session.check_acquisition_status()
Expand Down
7 changes: 1 addition & 6 deletions src/nirfsg/system_tests/test_system_nirfsg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,12 +577,7 @@ def test_create_deembedding_sparameter_table_s2p_file(self, rfsg_device_session)
with rfsg_device_session.initiate():
rfsg_device_session.check_generation_status()
rfsg_device_session.delete_all_deembedding_tables()
try:
rfsg_device_session.commit()
assert False
except nirfsg.Error as e:
assert e.code == -1074097772
assert 'The specified de-embedding table cannot be found' in e.description
rfsg_device_session.commit()
rfsg_device_session.ports[''].deembedding_selected_table = ''
with rfsg_device_session.initiate():
rfsg_device_session.check_generation_status()
Expand Down
Loading