Skip to content

Adding Diode Test example in NI-DMM - #2224

Open
NI-velmurugan wants to merge 5 commits into
ni:masterfrom
NI-velmurugan:users/velmurugan/add-nidmm-diode-measurement
Open

NI-velmurugan wants to merge 5 commits into
ni:masterfrom
NI-velmurugan:users/velmurugan/add-nidmm-diode-measurement

Conversation

@NI-velmurugan

@NI-velmurugan NI-velmurugan commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor
  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
    - [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

This PR adds nidmm_diode_test.py, a Python adaptation of the LabVIEW Diode Test.vi

What testing has been done?

Manually tested the example using simulated hardware and the real hardware

@codecov-commenter

codecov-commenter commented Oct 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.45%. Comparing base (cdbd8f2) to head (e7d3d9a).
⚠️ Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (cdbd8f2) and HEAD (e7d3d9a). Click for more details.

HEAD has 75 uploads less than BASE
Flag BASE (cdbd8f2) HEAD (e7d3d9a)
nifakeunittests 15 5
nidcpowerunittests 15 5
nidigitalunittests 15 5
nimodinstunittests 15 5
nirfsaunittests 15 5
niscopeunittests 15 5
nitclkunittests 15 5
codegenunittests 3 1
nidigitalsystemtests 1 0
nirfsasystemtests 1 0
nidcpowersystemtests 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2224      +/-   ##
==========================================
- Coverage   88.11%   80.45%   -7.67%     
==========================================
  Files          88       76      -12     
  Lines       22832    17178    -5654     
==========================================
- Hits        20119    13820    -6299     
- Misses       2713     3358     +645     
Flag Coverage Δ
codegenunittests 84.78% <ø> (ø)
nidcpowersystemtests ?
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests ?
nidigitalunittests 68.43% <ø> (ø)
nidmmsystemtests 92.33% <ø> (ø)
nifakeunittests 86.08% <ø> (ø)
nifgensystemtests 84.75% <ø> (-9.59%) ⬇️
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsasystemtests ?
nirfsaunittests 63.40% <ø> (ø)
nirfsgsystemtests 70.08% <ø> (-11.10%) ⬇️
niscopesystemtests 89.99% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 81.66% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NI-velmurugan NI-velmurugan changed the title Adding Diode Measurement example in NI-DMM Adding Diode Test example in NI-DMM Oct 13, 2026
@Avinash2Suresh

Copy link
Copy Markdown

Approved!

@NI-velmurugan

Copy link
Copy Markdown
Contributor Author

@jarnoldNI, the PR is ready for your review.

@NI-velmurugan
NI-velmurugan marked this pull request as ready for review October 14, 2026 04:54
Comment thread src/nidmm/examples/nidmm_diode_test.py Outdated
Comment thread src/nidmm/examples/nidmm_diode_test.py Outdated
Comment thread src/nidmm/examples/nidmm_diode_test.py Outdated
@ni-jfitzger

Copy link
Copy Markdown
Collaborator

Pull main and it should fix the system tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants